Skip to content

test: isolate Qwen provider resolution from local pools - #67465

Open
crazyief wants to merge 1 commit into
NousResearch:mainfrom
crazyief:fix/test-suite-stability-20260719
Open

test: isolate Qwen provider resolution from local pools#67465
crazyief wants to merge 1 commit into
NousResearch:mainfrom
crazyief:fix/test-suite-stability-20260719

Conversation

@crazyief

Copy link
Copy Markdown

Summary

  • isolate the Qwen singleton credential resolver test from the higher-priority credential pool
  • force an empty-pool precondition in the Qwen auto-fallthrough test
  • keep both tests deterministic when the canonical runner preserves a developer's real HOME

Why

resolve_runtime_provider() correctly checks the credential pool before the singleton Qwen resolver. On machines with Qwen credentials under ~/.qwen, these tests can resolve the real pool entry instead of exercising their mocked resolver or auth-failure path.

The production priority is correct; the tests were missing the empty-pool precondition.

Test plan

  • scripts/run_tests.sh -j 2 tests/hermes_cli/test_models.py tests/hermes_cli/test_runtime_provider_resolution.py -q --tb=short
  • 235 tests passed, 0 failed on current origin/main
  • git diff --check origin/main...HEAD

Scope

Test-only change. No runtime provider behavior is modified.

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/cli CLI entry point, hermes_cli/, setup wizard provider/qwen Qwen / Alibaba Cloud (OAuth) P3 Low — cosmetic, nice to have labels Jul 19, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused test stabilization. Current main loads a credential pool before the Qwen singleton resolver (hermes_cli/runtime_provider.py:1695-1760), while Qwen CLI credentials are read from Path.home() / ".qwen" (hermes_cli/auth.py:2303-2316) and the shared fixture deliberately preserves HOME (tests/conftest.py:359-365). The two added empty-pool preconditions therefore exercise the intended mocked singleton and auto-fallthrough paths without changing production behavior.

Automated hermes-sweeper review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/qwen Qwen / Alibaba Cloud (OAuth) sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants