test: isolate Qwen provider resolution from local pools - #67465
Open
crazyief wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the focused test stabilization. Current main loads a credential pool before the Qwen singleton resolver ( Automated hermes-sweeper review. |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HOMEWhy
resolve_runtime_provider()correctly checks the credential pool before the singleton Qwen resolver. On machines with Qwen credentials under~/.qwen, these tests can resolve the real pool entry instead of exercising their mocked resolver or auth-failure path.The production priority is correct; the tests were missing the empty-pool precondition.
Test plan
scripts/run_tests.sh -j 2 tests/hermes_cli/test_models.py tests/hermes_cli/test_runtime_provider_resolution.py -q --tb=shortorigin/maingit diff --check origin/main...HEADScope
Test-only change. No runtime provider behavior is modified.