fix(copilot): add dash-notation aliases for Claude model IDs - #6743
Closed
dsr-restyn wants to merge 1 commit into
Closed
dsr-restyn wants to merge 1 commit into
dsr-restyn wants to merge 1 commit into
Conversation
The default model name format in Hermes config uses dashes (claude-sonnet-4-6) but Copilot's API requires dots (claude-sonnet-4.6). Users switching to provider: copilot without updating their model name get an HTTP 400 'model not supported' error with no clear guidance. Add dash-to-dot aliases in _COPILOT_MODEL_ALIASES for all current Claude models served via Copilot, so normalize_copilot_model_id() silently resolves them to the correct ID.
1 task done
teknium1
added a commit
that referenced
this pull request
Apr 17, 2026
…6879) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes #6879 Credits dsr-restyn (#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
teknium1
added a commit
that referenced
this pull request
Apr 17, 2026
…6879) (#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes #6879 Credits dsr-restyn (#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
Collaborator
|
Closing — salvaged via PR #11561 (commit 29d5d36). Your dash-notation aliases are in the merged fix, bundled with a repair of |
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ousResearch#6879) (NousResearch#11561) The Copilot API returns HTTP 400 "model_not_supported" when it receives a model ID it doesn't recognize (vendor-prefixed like `anthropic/claude-sonnet-4.6` or dash-notation like `claude-sonnet-4-6`). Two bugs combined to leave both formats unhandled: 1. `_COPILOT_MODEL_ALIASES` in hermes_cli/models.py only covered bare dot-notation and vendor-prefixed dot-notation. Hermes' default Claude IDs elsewhere use hyphens (anthropic native format), and users with an aggregator-style config who switch `model.provider` to `copilot` inherit `anthropic/claude-X-4.6` — neither case was in the table. 2. The Copilot branch of `normalize_model_for_provider()` only stripped the vendor prefix when it matched the target provider (`copilot/`) or was the special-cased `openai/` for openai-codex. Every other vendor prefix survived to the Copilot request unchanged. Fix: - Add dash-notation aliases (`claude-{opus,sonnet,haiku}-4-{5,6}` and the `anthropic/`-prefixed variants) to the alias table. - Rewire the Copilot / Copilot-ACP branch of `normalize_model_for_provider()` to delegate to the existing `normalize_copilot_model_id()`. That function already does alias lookups, catalog-aware resolution, and vendor-prefix fallback — it was being bypassed for the generic normalisation entry point. Because `switch_model()` already calls `normalize_model_for_provider()` for every `/model` switch (line 685 in model_switch.py), this single fix covers the CLI startup path (cli.py), the `/model` slash command path, and the gateway load-from-config path. Closes NousResearch#6879 Credits dsr-restyn (NousResearch#6743) who independently diagnosed the dash-notation case; their aliases are folded into this consolidated fix alongside the vendor-prefix stripping repair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching to
provider: copilotwith the default model name (claude-sonnet-4-6, dashes) produces an immediate HTTP 400 "The requested model is not supported" because Copilot's API requires dot-notation (claude-sonnet-4.6). There's no error message pointing at the naming mismatch — users have to figure it out by trial and error.What changed
hermes_cli/models.py_COPILOT_MODEL_ALIASESnormalize_copilot_model_id()already runs on every Copilot API call and resolves aliases before the request is sent. The new entries silently mapclaude-{model}-4-6→claude-{model}-4.6so users don't need to update their config when switching providers.Type of Change
How to Test
Set
model.provider: copilotandmodel.default: claude-sonnet-4-6(dashes) in config.yaml. Before this fix: HTTP 400. After: request succeeds with the correct model ID forwarded to Copilot.Closes #6879