Skip to content

fix(models): surface Kimi Coding k3 when searching kimi - #67409

Open
HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/kimi-k3-search-alias
Open

fix(models): surface Kimi Coding k3 when searching kimi#67409
HexLab98 wants to merge 2 commits into
NousResearch:mainfrom
HexLab98:fix/kimi-k3-search-alias

Conversation

@HexLab98

@HexLab98 HexLab98 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • scripts/run_tests.sh tests/hermes_cli/test_model_search.py tests/hermes_cli/test_curses_ui_fuzzy_rank.py -q
  • cd ui-tui && npm test -- --run src/lib/model-search-text.test.ts
  • Dashboard → Models → MoA → Change → Kimi For Coding / Kimi Coding Plan → search kimi → confirm k3 appears
  • Same picker → search k3 → still finds it
  • With a Coding Plan key, clear search → k3 still only appears via live discovery (not a static catalog entry)

@HexLab98
HexLab98 force-pushed the fix/kimi-k3-search-alias branch from 1da5fbf to 307a166 Compare July 19, 2026 09:35
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/desktop Electron desktop app (apps/desktop/*) comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/dashboard Web dashboard / control panel UI (dashboard/, landing) provider/kimi Kimi / Moonshot labels Jul 19, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Related to merged #65922 and closed #65969: this PR leaves K3 discovery and its wire ID unchanged, adding only synchronized picker-search aliases across the UI surfaces.

HexLab98 added 2 commits July 19, 2026 16:55
Kimi Coding discovers the flagship as wire id `k3`. Picker search used
only that id, so typing "kimi" hid it next to every other kimi-* model.
Add picker-only search aliases without changing the wire id.
Assert the picker haystack keeps ordinary ids unchanged, surfaces wire
id k3 for "kimi"/"k3" queries, and accept search_labels in curses mocks.
@HexLab98
HexLab98 force-pushed the fix/kimi-k3-search-alias branch from df2ce32 to 0a7dfab Compare July 19, 2026 09:56
@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 19, 2026
teknium1 added a commit that referenced this pull request Jul 27, 2026
Follow-up to the salvaged #67409 search aliases: with kimi-k3 now in
the curated kimi-coding list (#68108), a Coding Plan key rendered TWO
rows for one model — curated 'kimi-k3' plus live-discovered bare 'k3'
(merge dedup was exact-string). Add model_alias_canonical() derived
from the same alias table and use it as the merge dedup key, so the
curated public slug wins and live-only models still surface.
teknium1 added a commit that referenced this pull request Jul 27, 2026
Follow-up to the salvaged #67409 search aliases: with kimi-k3 now in
the curated kimi-coding list (#68108), a Coding Plan key rendered TWO
rows for one model — curated 'kimi-k3' plus live-discovered bare 'k3'
(merge dedup was exact-string). Add model_alias_canonical() derived
from the same alias table and use it as the merge dedup key, so the
curated public slug wins and live-only models still surface.
teknium1 added a commit that referenced this pull request Jul 27, 2026
Follow-up to the salvaged #67409 search aliases: with kimi-k3 now in
the curated kimi-coding list (#68108), a Coding Plan key rendered TWO
rows for one model — curated 'kimi-k3' plus live-discovered bare 'k3'
(merge dedup was exact-string). Add model_alias_canonical() derived
from the same alias table and use it as the merge dedup key, so the
curated public slug wins and live-only models still surface.

@GottZ GottZ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by AI during triage.

Summary

Two PRs address the same picker-search failure: #67409 adds picker-only aliases so the live k3 wire ID matches “kimi” across CLI, TUI, web, and desktop, while #68153 carries that fix onto current main and additionally deduplicates live k3 against curated kimi-k3.

Related pull requests

  • #67409 related — (+243/-8) — superseded duplicate: Adds synchronized k3 search aliases across all picker surfaces without changing the wire ID or adding a static catalog entry, directly addressing the reported search failure. Its implementation was salvaged into #68153, whose diff also handles the resulting k3/kimi-k3 duplicate-row case.
  • #68153 [merged] duplicate — (+354/-12) — merged reference implementation: Preserves #67409’s cross-picker search-alias fix and adds canonical alias-based merge deduplication so curated kimi-k3 and live k3 do not appear as two rows; it remains relevant because it is the merged implementation that supersedes #67409.

Duplicates

#67409 and #68153 implement substantially the same cross-picker k3kimi search-alias change; #68153 is the superseding version with additional alias-aware deduplication.

Suggested consolidation

Close #67409 as duplicate of #68153: #68153 explicitly salvages its picker-search fix, includes the same affected surfaces and tests, and extends it with regression coverage and canonical deduplication for k3 versus kimi-k3. The duplicate chain is #67409#68153, with #68153 already serving as the merged reference implementation.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    subgraph Dup67409 ["PRs duplicating each other"]
        P67409["PR #67409 (open)"]
        P68153["PR #68153 (merged)"]
    end
    class P67409 open
    class P68153 merged
    class P67409 target
    click P67409 "https://github.com/NousResearch/hermes-agent/pull/67409"
    click P68153 "https://github.com/NousResearch/hermes-agent/pull/68153"
Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 37 kB of PR diffs, 3 kB of issue/PR text, <1 kB of discussion (2 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
Follow-up to the salvaged NousResearch#67409 search aliases: with kimi-k3 now in
the curated kimi-coding list (NousResearch#68108), a Coding Plan key rendered TWO
rows for one model — curated 'kimi-k3' plus live-discovered bare 'k3'
(merge dedup was exact-string). Add model_alias_canonical() derived
from the same alias table and use it as the merge dedup key, so the
curated public slug wins and live-only models still surface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/desktop Electron desktop app (apps/desktop/*) comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have provider/kimi Kimi / Moonshot sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants