test(cron): add coverage for pre-set stop event

[devxMani]

Adds a unit test covering the edge case where the in-process cron scheduler is started with an already-set stop event.

The test verifies that the scheduler exits cleanly without continuing background work when shutdown has already been requested. This improves test coverage around the scheduler lifecycle without modifying production code.

Related to #67102

• ✅ Tests (adding or improving test coverage)

• Added a new unit test in tests/cron/test_scheduler_provider.py.

• Covered the scenario where InProcessCronScheduler starts with the stop event already set.

• No production code was modified.

1. Run the cron scheduler test suite.
2. Verify the new test executes successfully.
3. Confirm existing cron scheduler tests continue to pass.

[alt-glitch]

This was generated by AI during triage.

Related: this adds the pre-set stop_event scheduler-provider test requested by #67102; the broader ticker coverage request remains open.

[teknium1]

Thanks for adding the focused lifecycle coverage. Current main dispatches cron_tick() only inside the while not stop_event.is_set() guard in cron/scheduler_provider.py:192; the new test directly protects that pre-start shutdown behavior. The existing test at tests/cron/test_scheduler_provider.py:147 verifies shutdown after the ticker has started, so this is not duplicate coverage.

This is an automated hermes-sweeper review.

[GottZ]

This was generated by AI during triage.

Summary

Nine open PRs are associated with this complex: #44049, #44050, #46207, #47358, #52259, and #67418 address the Desktop-versus-Gateway cron race, while #67135, #67198, and #67204 add scheduler-provider tests without changing scheduler ownership. The fix diffs range from obsolete direct-ticker guards and startup suppression to provider-aware runtime-lock deferral; the recorded cross-issue best-fix selection is #44050, although every PR header records verify_verdikt=n/a.

Related pull requests

• fix(cron): defer desktop ticker to gateway scheduler owner #44049 partial — (+211/-13) — n/a: Adds scheduler-level runtime-lock deferral, threads it through the provider and Chronos interfaces, and opts the Desktop ticker in, addressing the reported provenance and adapterless-delivery cause but substantially duplicating fix(cron): yield desktop ticker to running gateway #44050 with a broader interface change.
• fix(cron): yield desktop ticker to running gateway #44050 best fix — (+219/-14) — n/a; recorded best fix for [Bug]: Desktop dashboard cron ticker can execute jobs instead of launchd gateway, breaking macOS TCC/FDA provenance #43965, Desktop dashboard cron scheduler races the gateway; when it wins a tick it has no live adapter and delivery hangs until script_timeout (600s) #52202, and Desktop serve cron ticker silently degrades Feishu interactive cards to plain text #66629: Carries owner deferral through the active built-in-provider path while preserving the Gateway default and external-provider contracts; its updated diff addresses the keep_open review with provider-boundary, owner/no-owner, Gateway-default, and external-provider tests.
• fix(desktop): skip dashboard cron tick while the profile gateway is alive #46207 partial — (+83/-2) — n/a: Checks Gateway liveness before each Desktop tick and fails open, but patches the removed direct cron_tick() loop; despite its keep_open review, fix(cron): yield desktop ticker to running gateway #44050 implements the requested provider-aware port on the active path.
• fix(desktop): yield cron ownership to running gateway #47358 partial — (+73/-3) — n/a: Uses get_running_pid() to stand down the old Desktop ticker for macOS TCC provenance, but its production hunk and tests bypass the provider dispatch introduced by abbd864; despite the automated keep_open verdict, fix(cron): yield desktop ticker to running gateway #44050 covers that active path.
• fix(desktop): don't start a cron scheduler when a live gateway owns cron (#52202) #52259 partial — (+456/-16) — n/a: Suppresses Desktop scheduling at startup, stops an active built-in ticker when a Gateway later appears, and separately bounds standalone sends to 30 seconds; despite its keep_open verdict, the ownership portion overlaps fix(cron): yield desktop ticker to running gateway #44050 and the stopped ticker does not automatically resume after a later Gateway exit, while the timeout work remains salvageable.
• test(cron): add coverage for pre-set stop event #67135 related — (+26/-0) — n/a: Adds focused coverage proving that a pre-set stop_event prevents InProcessCronScheduler from ticking, with no production ownership change; its high-salvageability keep_open verdict identifies this as non-duplicate lifecycle coverage for hermes_cli/cron.py background ticker lacks dedicated unit tests #67102.
• test(cron): cover ticker interval, adapter/loop forwarding, and recovery ordering #67198 related — (+155/-0) — n/a: Adds exact interval, adapter/loop forwarding, recovery-before-first-tick, and compatibility-shim tests without changing Desktop-versus-Gateway arbitration; its high-salvageability keep_open verdict supports retaining this complementary scheduler-provider coverage.
• test(cron): cover ticker inter-tick interval pacing (#67102) #67204 related — (+46/-0) — n/a: Adds a real-time inter-tick pacing test without changing production arbitration or delivery; its keep_open review supports the test but requests correction or removal of the inaccurate 1.5× jitter-margin comment.
• fix(cron): desktop ticker defers to a live gateway instead of racing it #67418 partial — (+849/-16) — n/a: Adds a provider-aware per-tick gate, automatic Desktop resumption, a read-only Gateway lock-record classifier, and extensive PID/profile hardening; despite its keep_open review and redesign, the documented scan-to-claim handoff window remains, so the ownership result overlaps fix(cron): yield desktop ticker to running gateway #44050 while the status hardening is independently salvageable.

Duplicates

#44049 and #44050 implement substantially the same runtime-lock-backed scheduler deferral; #46207 and #47358 are obsolete direct-ticker variants, while the ownership portions of #52259 and #67418 address the same race through broader lifecycle, timeout, or status-probe changes. #67135, #67198, and #67204 are complementary test PRs, not ownership-fix duplicates.

Suggested consolidation

Author action: rebase #44050 onto current main while preserving its built-in-only provider integration and regression coverage; this retains the recorded best-fix target without making a merge recommendation. Then close #44049, #46207, and #47358 as duplicates of #44050, and split the standalone-send timeout from #52259 and independently justified status/profile hardening from #67418 before closing their remaining ownership portions as duplicates; despite the keep_open reviews on #46207, #47358, #52259, and #67418, the first two target the obsolete direct-ticker path and the latter two contain distinct salvageable work around an overlapping ownership fix. Keep #67135 and #67198 open for their complementary scheduler-test coverage, and keep #67204 open after the review-requested comment correction.

Cross-PR triage: Reviewed 9 pull requests and 3 issues in this complex. Each diff was read against this issue; Assessment working set: 114 kB of PR diffs, 42 kB of issue/PR text, 15 kB of discussion (22 comments), 25 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.