fix(nix): include apps/shared in tui build source - #67098
Closed
Chronicuser21 wants to merge 1 commit into
Closed
Conversation
The TUI now depends on @hermes/shared (file:../apps/shared), which exports @hermes/shared/charge-settlement (used by topup.ts). The Nix build's filtered source tree only included ui-tui/, so apps/shared/src/ was missing in the build sandbox. The symlink from npm install pointed nowhere, and esbuild couldn't resolve the module. Following the same pattern used by web.nix and desktop.nix, which both include apps/shared in their dirs with this exact rationale.
alt-glitch
added
type/bug
Collaborator
Duplicate of open #67082: both repairs add apps/shared to the Nix TUI source filter for the same workspace-resolution failure. |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nix run github:NousResearch/hermes-agent#desktopfails:The TUI now depends on
@hermes/shared(viaui-tui/package.json:"@hermes/shared": "file:../apps/shared"), andtopup.tsimports@hermes/shared/charge-settlement. However, the Nix build forhermes-tui(nix/tui.nix) only includedui-tui/in its filtered source tree — theapps/shared/source was missing from the build sandbox. npm install symlinkednode_modules/@hermes/sharedto a directory that didn't exist in the sandbox, so esbuild couldn't resolve the import.Fix
Add
"apps/shared"to thedirslist innix/tui.nixso the shared package source is available during the esbuild bundle step.This follows the exact same pattern already used by
nix/web.nixandnix/desktop.nix— both includeapps/sharedwith the comment@hermes/shared ships as a file: workspace dep of ... so its source must be in the filtered src tree too.