feat(dashboard): browser.headed schema toggle (#25653 salvage) - #67046
Merged
Conversation
Salvaged from PR #25653 by @Black0Fox0 — the config-key and env-wiring halves of that PR landed via #67018; this carries the surviving dashboard schema override so browser.headed renders as a labeled boolean toggle. Description updated to reflect the merged cleanup-skip behavior.
alt-glitch
added
type/feature
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard now renders
browser.headedas a labeled boolean toggle — salvages the surviving piece of PR #25653 by @Black0Fox0.The other two thirds of #25653 (the
browser.headedDEFAULT_CONFIG key and the headed-mode wiring inbrowser_tool.py) already landed via PR #67018, which went further than the env-var bridge #25653 proposed (--headedCLI flag + per-turn cleanup skip). This PR carries the one piece #67018 didn't cover: the_SCHEMA_OVERRIDESentry inhermes_cli/web_server.pyso the dashboard shows a proper toggle with a description instead of a bare untyped key.Changes
hermes_cli/web_server.py:browser.headedschema override (boolean type + description). Description updated from the original to reflect the merged behavior (window persists between turns, idle reaper still applies).contributors/emails/ayoub@gmail.com: contributor mapping for @Black0Fox0.Validation
_SCHEMA_OVERRIDESshape (type,description)Contributor authorship preserved (
--author="Ayoub <ayoub@gmail.com>", rebase-merge).Infographic