fix(setup): skip camofox npm install in uv tool-install mode (#66044)

[Enough1122]

Summary

_run_post_setup('camofox') in hermes_cli/tools_config.py always runs npm install --workspaces=false in PROJECT_ROOT = Path(__file__).parent.parent.resolve(). On a source checkout this resolves to the repo root (with package.json) and works fine.

On a uv tool install install, PROJECT_ROOT resolves to ~/.local/share/uv/tools/hermes-agent/ — a uv-managed package directory with no package.json. The npm install call then either errors out (npm ERR! ... doesn't have any package.json) or, depending on cwd, runs but fails.

Worse, install.sh deletes any pre-existing ~/.hermes/hermes-agent source checkout before the new install completes. So a camofox-choice crash during setup leaves the user with neither an old nor a new install: uv tool list is empty, ~/.hermes/hermes-agent is gone, the post-setup traceback ends in FileNotFoundError on the now-deleted checkout path. Issue #66044.

This affects every Linux user who picks camofox during hermes setup on a uv tool install install, plus every user who previously had a source-based install and tried to migrate via install.sh.

Fix

Detect uv mode by the absence of package.json in PROJECT_ROOT and skip the npm install step entirely. Users in that mode get a clear message to run npx @askjo/camofox-browser directly (or use the Docker image).

Source-checkout behavior is unchanged — package.json is present, the existing install path runs as before.

Single-file change in hermes_cli/tools_config.py::_run_post_setup('camofox'). No public API change. No new imports.

Test plan

1. Install via uv tool install (no ~/.hermes/hermes-agent checkout).
2. Run hermes setup.
3. Pick camofox as the browser provider.
4. Expected: setup completes successfully (no FileNotFoundError); user sees a message saying "Skipping Camofox npm install (no source checkout found). Start the Camofox server directly: npx @askjo/camofox-browser".
5. Without this fix: setup crashes with FileNotFoundError: '/home/<user>/.hermes/hermes-agent' and the user is left with no working install.

Fixes #66044.

[alt-glitch]

This was generated by AI during triage.

Related to #66044. This narrowly guards the uv-tool-install Camofox setup path while preserving source-checkout behavior.

[Enough1122]

The branch was force-pushed after an earlier triage bot comment (alt-glitch) flagged the diff as a multi-fix superset. That comment was based on the initial push which had accumulated prior PR commits because I forgot to rebase onto main before opening the next branch — fixed now.

Current diff is single-file and matches the PR description exactly:

• fix(desktop): new session inherits active project cwd when not entered (#66686) #66898: apps/desktop/src/store/projects.ts only (+29 / −7)
• fix(tools): preserve active venv on PATH across login-shell snapshots (#66642) #66902: tools/environments/local.py only (+17 / −0)
• fix(agent): close Codex app-server subprocess on AIAgent.close() (#66671) #66904: run_agent.py only (+16 / −0)
• fix(state): probe FTS5 read path in _db_opens_cleanly so partial index corruption is detected (#66724) #66906: hermes_state.py only (+30 / −0). The probe now also catches sqlite3.DatabaseError (the malformed-shadow-table class session_search fails with 'database disk image is malformed' while hermes sessions repair reports clean #66724 actually wants caught) — OperationalError was insufficient; verified by hand with a corrupted FTS5 index.
• fix(setup): skip camofox npm install in uv tool-install mode (#66044) #66908: hermes_cli/tools_config.py only (+26 / −11)

This AI-assisted PR was drafted by Hermes Agent on behalf of @Enough1122. Happy to rebase / split / close if reviewers prefer a different shape.

[teknium1]

Thanks for the focused investigation. This automated hermes-sweeper review found that the #66044 failure path is already addressed on current main.

• scripts/install.sh:1178-1188 preserves an interrupted checkout by moving it to a timestamped backup, and scripts/install.sh:1190-1269 updates a valid checkout in place rather than deleting it.
• scripts/install.sh:2267-2273 runs setup from $INSTALL_DIR via its venv, so the Camofox post-setup cwd is the managed source checkout.
• hermes_cli/tools_config.py:1282-1296 handles a failed Camofox npm invocation as a warning; it does not raise on npm's non-zero exit.
• The related issue install.sh + setup with camofox provider: post-setup crashes on missing source dir, leaves no working hermes install #66044 is already closed after a current-main cannot_reproduce review.

The proposed package.json guard therefore targets an installer state that current main no longer reaches.