fix(update): refresh pinnedCommit in .hermes-bootstrap-complete after git pull - #66905
Open
hotter909 wants to merge 1 commit into
Open
fix(update): refresh pinnedCommit in .hermes-bootstrap-complete after git pull#66905hotter909 wants to merge 1 commit into
hotter909 wants to merge 1 commit into
Conversation
… git pull The Desktop app uses .hermes-bootstrap-complete to decide whether to skip CLI verification and go straight to createActiveBackend(). When hermes update runs git pull, HEAD changes but the pinnedCommit stays stale, so the next Desktop launch from a desktop entry (clean PATH, no proxy env) falls through to CLI verification or bootstrap — both eventually fail. Add _refresh_bootstrap_pin() that reads the marker, updates pinnedCommit and completedAt to match the new HEAD, and calls it at the end of _cmd_update_impl after ✓ Update complete!.
alt-glitch
added
type/bug
Collaborator
teknium1
reviewed
Jul 19, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracing the bootstrap marker/update interaction. The proposed condition is not used by current Desktop startup.
Problems
apps/desktop/electron/main.ts:3057-3064deliberately does not comparepinnedCommitwith checkoutHEAD; it treats the marker as evidence that bootstrap completed and instead requires a runnable active runtime.apps/desktop/electron/main.ts:3330-3331callscreateActiveBackend()whenever that check succeeds. RewritingpinnedCommitafterhermes updatetherefore does not change the backend-selection path.
Suggested changes
- Please remove this refresh, or re-scope it to a currently reproducible failure in the runtime-usability checks and cover that behavior with a regression test.
Automated hermes-sweeper review.
teknium1
added
sweeper:blast-contained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Desktop app keys off
.hermes-bootstrap-complete— when pinnedCommit matches HEAD it skips CLI verification and goes straight to createActiveBackend(). After hermes update runs git pull, HEAD changes but the pin stays stale, so the next Desktop launch from a desktop entry (clean PATH, no proxy) falls through to CLI verification or bootstrap, both of which fail.Adds _refresh_bootstrap_pin() that updates pinnedCommit + completedAt to match the new HEAD, called at the end of _cmd_update_impl after ✓ Update complete!.
⋅⋅⋅