fix(error_classifier): stop empty-response advisories from triggering compression - #66818
Merged
teknium1 merged 2 commits intoJul 18, 2026
Merged
Conversation
Collaborator
… compression Provider empty-reply text mentions "very low max_tokens", which used to match the bare overflow pattern and thrash compress until "Cannot compress further".
HexLab98
force-pushed
the
fix/empty-response-max-tokens-misclass
branch
from
July 18, 2026 08:31
be3bfc7 to
4ac928c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_CONTEXT_OVERFLOW_PATTERNS, so Hermes misclassified the error as context overflow, entered the compression loop, and ended in "Cannot compress further" on otherwise healthy sessions.Test plan