fix(cron): accept UTF-8 BOM job stores - #66763
Closed
HengYangDS wants to merge 1 commit into
Closed
Conversation
Author
|
Duplicate of #66609, which already contains the same four |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66607: a UTF-8 BOM at the start of
~/.hermes/cron/jobs.jsonno longer prevents the cron store,hermes dump, orhermes statusfrom reading scheduled jobs.All four jobs-store reads now use
utf-8-sig; writes remain plain UTF-8, so the next successful write naturally produces a BOM-free file.Validation
python -m pytest tests/cron/test_jobs.py::TestJobCRUD::test_load_jobs_reads_utf8_bom_store tests/hermes_cli/test_dump_env_visibility.py tests/hermes_cli/test_status.py tests/hermes_cli/test_cron.py -q— 39 passedruff checkon the changed files — passedscripts/check-windows-footguns.pyon the changed files — passedgit diff --check— passedjobs.json:load_jobs(), dump summary, and status all reported one active job.