Skip to content

fix(cron): accept UTF-8 BOM job stores - #66763

Closed
HengYangDS wants to merge 1 commit into
NousResearch:mainfrom
HengYangDS:fix/cron-jobs-bom-66607
Closed

fix(cron): accept UTF-8 BOM job stores#66763
HengYangDS wants to merge 1 commit into
NousResearch:mainfrom
HengYangDS:fix/cron-jobs-bom-66607

Conversation

@HengYangDS

Copy link
Copy Markdown

Summary

Fixes #66607: a UTF-8 BOM at the start of ~/.hermes/cron/jobs.json no longer prevents the cron store, hermes dump, or hermes status from reading scheduled jobs.

All four jobs-store reads now use utf-8-sig; writes remain plain UTF-8, so the next successful write naturally produces a BOM-free file.

Validation

  • python -m pytest tests/cron/test_jobs.py::TestJobCRUD::test_load_jobs_reads_utf8_bom_store tests/hermes_cli/test_dump_env_visibility.py tests/hermes_cli/test_status.py tests/hermes_cli/test_cron.py -q — 39 passed
  • ruff check on the changed files — passed
  • scripts/check-windows-footguns.py on the changed files — passed
  • git diff --check — passed
  • Runtime probe with a BOM-prefixed jobs.json: load_jobs(), dump summary, and status all reported one active job.

@HengYangDS

Copy link
Copy Markdown
Author

Duplicate of #66609, which already contains the same four utf-8-sig reader changes and broader BOM coverage. Closing this duplicate to keep review and CI on the established PR.

@HengYangDS HengYangDS closed this Jul 18, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cron Cron scheduler and job management comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels Jul 18, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Hermes Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cron: UTF-8 BOM in jobs.json crashes load_jobs (RuntimeError)

3 participants