Skip to content

fix(pairing): stop labeling hash fingerprint as 'Code' in list output #66761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lhridley wants to merge 1 commit into from
Closed

fix(pairing): stop labeling hash fingerprint as 'Code' in list output #66761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions hermes_cli/pairing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
hermes pairing clear-pending # Clear all expired/pending codes
"""

import re

def pairing_command(args):
"""Handle hermes pairing subcommands."""
from gateway.pairing import PairingStore
Expand Down Expand Up @@ -39,13 +41,20 @@ def _cmd_list(store):

if pending:
print(f"\n Pending Pairing Requests ({len(pending)}):")
print(f" {'Platform':<12} {'Code':<10} {'User ID':<20} {'Name':<20} {'Age'}")
print(f" {'--------':<12} {'----':<10} {'-------':<20} {'----':<20} {'---'}")
print(f" {'Platform':<12} {'Request ID':<10} {'User ID':<20} {'Name':<20} {'Age'}")

@teknium1 teknium1 Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The displayed value is a truncated SHA-256 hash prefix, not the stored request entry ID (gateway/pairing.py:453-458, gateway/pairing.py:561-565). Fingerprint or Hash prefix would be accurate here.

print(f" {'--------':<12} {'----------':<10} {'-------':<20} {'----':<20} {'---'}")
for p in pending:
print(
f" {p['platform']:<12} {p['code']:<10} {p['user_id']:<20} "
f"{(p.get('user_name') or ''):<20} {p['age_minutes']}m ago"
)
print(
" Note: 'Request ID' is a hash fingerprint for identifying this"
)
print(
" request. To approve, use the CODE the bot sent you in chat —")
print(
" run `hermes pairing approve <platform> <code>`.\n")
else:
print("\n No pending pairing requests.")

Expand All @@ -64,8 +73,27 @@ def _cmd_list(store):
def _cmd_approve(store, platform: str, code: str):
"""Approve a pairing code."""
platform = platform.lower().strip()
code = code.upper().strip()
code = code.strip()

# Guard against the misleading `pairing list` fingerprint: it is the first
# 8 hex chars of the code's SHA-256 hash, NOT the approvable code. Reject
# hash-prefix input explicitly so operators don't chase a "wrong code"
# rabbit hole (the real code comes from the bot's DM).
if re.fullmatch(r"[0-9a-fA-F]{8}", code):

@teknium1 teknium1 Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard also rejects legitimate pairing codes. gateway/pairing.py generates eight-character codes from an alphabet containing A-F and 2-9, so ABCDEF23 is valid and must reach approve_code(). Identify an input as a displayed fingerprint by comparing it with pending fingerprints, not by its shape.

print(
"\n That looks like the Request ID from `hermes pairing list` — "
"it is a"
)
print(
" hash fingerprint, not the approvable code. Approve with the CODE"
)
print(
" the bot sent you in Telegram/DM (e.g. `hermes pairing approve "
"telegram ABCD1234`).\n"
)
return

code = code.upper().strip()
result = store.approve_code(platform, code)
if result:
uid = result["user_id"]
Expand Down