fix(qqbot): add return_exceptions=True to asyncio.gather in chunked upload - #66657
Closed
x7peeps wants to merge 1 commit into
Closed
fix(qqbot): add return_exceptions=True to asyncio.gather in chunked upload#66657x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
Closing as duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
return_exceptions=Trueto theasyncio.gather()call in_run_with_concurrencyused by the QQBot chunked file upload pipeline.Problem
The
asyncio.gather()at gateway/platforms/qqbot/chunked_upload.py:602 had noreturn_exceptions=True. When uploading a multi-part file, if any single part upload failed (network error, server rejection, etc.),gather()would cancel all other concurrent uploads rather than letting them finish, wasting bandwidth and potentially leaving the upload in an inconsistent state. This is the same pattern already fixed in trajectory_compressor (PR #65932), context_references (PR #62902), and feishu (PR #64864).Fix
return_exceptions=Truetoasyncio.gather()so each part upload runs to completion regardless of sibling failures.-> Nonereturn contract of_run_with_concurrency.Testing