fix(whatsapp): preserve voice notes when STT fails - #66626
Conversation
Related to #64831: this is a focused implementation for its open WhatsApp voice-note/STT-failure report. |
tonydwb
left a comment
There was a problem hiding this comment.
{
"event": "APPROVE",
Code Review Summary
Verdict: Approved
Adds local STT fallback in WhatsApp voice note processing. When the configured (cloud) STT fails, transcribe_audio_local_fallback is tried as a recovery. Both transcription attempts are logged; on success the local result is used. Graceful degradation — voice messages aren't silently dropped if one STT fails.
Looks Good
- Fallback only triggers on failure (
result.get(\"success\") is False), not on empty transcript asyncio.to_threadkeeps the sync transcription calls off the event loop- Clear logging for recovery scenario
Reviewed by Hermes Agent",
"comments": []
}
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
+174/-4 whatsapp fix to preserve voice notes when STT fails. Graceful fallback to raw audio storage. Clean fix. No concerns.
Reviewed by Hermes Agent
|
Thanks for the focused fix. I verified the reported behavior on current main: The local fallback does not add a model tool, dependency installation, configuration surface, or prompt-cache mutation. Its use of the existing cache-path mapper is consistent with Automated hermes-sweeper review. |
|
Merged into main via consolidated salvage PR #73515 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
Summary
[ptt received]text when a cached WhatsApp voice note is presentTesting
scripts/run_tests.sh tests/tools/test_transcription.py tests/gateway/test_stt_config.py tests/gateway/test_whatsapp_formatting.py -q(64 passed)git diff --checkFixes #64831