fix(cron): read jobs.json with utf-8-sig to tolerate BOM (#66607)

[AlexFucuson9]

Summary

Fixes #66607 — load_jobs() crashes with RuntimeError when jobs.json has a UTF-8 BOM.

Root cause

Four readers of ~/.hermes/cron/jobs.json open with plain encoding='utf-8'. Python's json.load rejects a leading BOM (EF BB BF) under plain UTF-8.

Fix

Switch all four readers to encoding='utf-8-sig':

• cron/jobs.py:838 — load_jobs primary open
• cron/jobs.py:844 — load_jobs strict=False retry
• hermes_cli/dump.py:170 — _cron_summary
• hermes_cli/status.py:532 — show_status

Writers remain on plain utf-8 so saves stay BOM-free.

Testing

TMP=$(mktemp -d)
mkdir -p "$TMP/cron"
printf '{"jobs": []}
' > "$TMP/cron/jobs.json"
HERMES_HOME="$TMP" python -c 'from cron.jobs import load_jobs; print(load_jobs())'
rm -rf "$TMP"

• py_compile passes on all 3 modified files
• No behavioral change for non-BOM files

[tonydwb]

Code Review Summary

Verdict: Approved with Comment

PR #66623 — fix(cron): read jobs.json with utf-8-sig to tolerate BOM

• Adds encoding='utf-8-sig' to Path.read_text() call in cron jobs loading.
• Fixes BOM handling for Windows-generated JSON files.
• 4-line change, well-scoped fix with clear rationale.
• No security implications; file reading only.

Suggestions

• Consider whether other Path.read_text() calls in the same file need the same treatment.

---

Reviewed by Hermes Agent

[alt-glitch]

This was generated by AI during triage.

Duplicate of #66609, which is open and implements the same utf-8-sig changes for all four jobs.json readers with broader regression coverage.

[tonydwb]

{
"event": "COMMENT",

Code Review Summary

Verdict: Comment (prior COMMENT activity noted)

Fixes jobs.json and _cron_summary reading to use utf-8-sig encoding instead of plain utf-8, tolerating BOM at the start of the file. Two read sites in cron/jobs.py and one in hermes_cli/dump.py updated.

---

Reviewed by Hermes Agent",
"comments": []
}

[teknium1]

Closing as a duplicate of #66609, which was submitted 31 minutes earlier with the identical 4-site utf-8-sig fix (cron/jobs.py ×2, hermes_cli/dump.py, hermes_cli/status.py) plus regression tests covering the crash repro, BOM-less regression, bare-list auto-repair, and the strict=False arm.

Credit to you for independently identifying all four readers — including the dump.py/status.py sites that the earlier #41604 missed. The fix will land via #66609. Thanks for the contribution!

[teknium1]

Merged via PR #66825, which salvaged #66609 (submitted ~30 minutes earlier with the same four utf-8-sig reader changes plus regression tests) as the base. Your PR independently identified the same fix including the dump.py/status.py sites — credited in the salvage PR body. Thanks!