fix(web): hide intermediate cmd.exe when opening profile terminal - #66612
fix(web): hide intermediate cmd.exe when opening profile terminal#66612stantheman0128 wants to merge 1 commit into
Conversation
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved with Comment
PR #66612 — fix(web): hide intermediate cmd.exe when opening profile terminal
- Hides intermediate
cmd.exewindow when opening profile terminal on Windows. - 20 additions, 4 deletions — targeted Windows UX fix.
- No security concerns.
Reviewed by Hermes Agent
Stan Shih (stantheman0128) Pass windows_hide_flags() to the Windows open-terminal Popen so the wrapper console does not flash; start still opens a visible terminal. Co-authored-by: Cursor <cursoragent@cursor.com>
c211e19 to
792aa0f
Compare
|
Closing after the class-level fix in PR #70205 (commit 0dbf639): Windows console flashes were caused by Hermes daemons running console-less (pythonw / DETACHED_PROCESS parents), forcing every console-subsystem child to allocate its own visible window. Main now launches every daemon (gateway, Scheduled Task, UAC handoff, dashboard, desktop backend) with a hidden console that all descendants inherit — so the spawn sites this PR flags no longer have a reachable flash under any shipped launch path (interactive terminals never flashed; children inherit the visible console there). The sites you patched were genuinely unflagged, and the diagnosis was sound against the old launch topology — the ground just moved under it. Rather than keep growing per-site flags across an unbounded set of leaf spawns, we're standardizing on the parent-console fix. If a flash reappears on current main under a shipped launch path, that's a new bug — please file it with the flashing process name. Thanks for the contribution and the Windows attention; sorry this one got mooted at the root. |
What does this PR do?
Hide the intermediate
cmd.execonsole flash when the portal opens a profile setup terminal on Windows.startstill opens a visible terminal for the user.Credit: Stan Shih (stantheman0128)
Related Issue
Unfiled Windows footgun found while auditing
open-terminalagainstwindows_hide_flags()coverage.Type of Change
Changes Made
hermes_cli/web_server.py: passcreationflags=windows_hide_flags()to the Windowsopen-terminalPopentests/hermes_cli/test_web_server.py: assertcreationflagson the Windows pathHow to Test
python -m pytest tests/hermes_cli/test_web_server.py::TestNewEndpoints::test_profile_open_terminal_uses_windows_cmd -qCREATE_NO_WINDOWPopen ofcmd.exe /c start /b ...returns exit 0Checklist
Code
Documentation & Housekeeping
AI assistance
Prepared with Cursor (Grok). Human reviewed.
Evidence