fix(desktop): isolate preview artifact chips per session view - #66578
stantheman0128 wants to merge 3 commits into
Conversation
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Critical
- None
Assessment
Adds contributor email record for TheUnathiCodex and a test regression file for the TUI gateway queue-on-busy behavior. Tests verify that busy submit correctly interrupts, queues, or steers based on the configured mode.
Looks Good
- New contributor added to emails directory
- Tests cover interrupt/queue/steer modes for busy state handling
_session(agent=agent, running=True)correctly simulates a running session
Reviewed by Hermes Agent
|
Thanks for the focused Desktop regression fix. The premise is confirmed on current main: The proposed Automated hermes-sweeper review. |
…search#66411) Co-authored-by: Cursor <cursoragent@cursor.com>
8530d36 to
915050d
Compare
|
Thanks for the overlapping work on #68683. That PR covers the same #66411 chip isolation case and also owns dismissal persistence across session switch / compress / restart via a session-owned publisher. Ours is the narrower write-path fix only. Happy to close this in favor of #68683 once that one lands (or sooner if maintainers prefer). Thanks @nv-cho for the fuller treatment and for the credit note. |
|
Closing as author to bring our open PRs on hermes-agent back within a healthy throttle (we had 10 open with only sweeper keep_open and no concrete maintainer change requests for days). Keeping three Windows-focused PRs open for now:
Happy to reopen this one if a maintainer wants it prioritized. Thanks for the patience. |
Summary
Closes #66411
Credit: Stan Shih (@stantheman0128). Developed with AI assistance (Cursor / Grok).
In multi-session Desktop split, tool fallback recorded HTML/localhost preview chips under the global
\. Both panes stay mounted, so focusing session A while session B's tool rows were still mounted re-keyed B's artifacts into A's composer status stack.The composer already reads
\[sessionId]per pane. This PR makes the write path match:ToolFallbackusesuseSessionView()(\/\) instead of the global active session stores.Verification
`
cd apps/desktop
npx vitest run --project ui src/components/assistant-ui/tool/fallback-preview-isolation.test.tsx src/components/assistant-ui/tool/fallback.test.ts src/components/assistant-ui/tool/fallback-model.test.ts
Test Files 3 passed | Tests 31 passed
`
`
python scripts/check-windows-footguns.py --diff HEAD~1
No Windows footguns found
`
Regression covers: tile view session-b with global active session-a records only under session-b.
Made with Cursor