fix(desktop): harden link title transport - #66459
Closed
HengYangDS wants to merge 1 commit into
Closed
HengYangDS wants to merge 1 commit into
HengYangDS wants to merge 1 commit into
Conversation
Contributor
Duplicate of #65613 — this later submission keeps the same link-title admission, DNS-pinning, SOCKS-routing, and fail-closed transport implementation; its additional timeout handling and E2E coverage are refinement of that open PR. |
HengYangDS
force-pushed
the
fix/desktop-link-title-ssrf-socks-publish-20260718
branch
from
July 17, 2026 19:18
a8921b5 to
de838d3
Compare
HengYangDS
marked this pull request as ready for review
July 18, 2026 05:10
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run typecheckand targeted ESLint passed.Note
The full Electron project suite has a pre-existing timeout in
electron/git-review-ops.test.ts, reproduced unchanged on the untouched local main checkout; it is not included in this PR scope.