Skip to content

fix(desktop): harden link title transport - #66459

Closed
HengYangDS wants to merge 1 commit into
NousResearch:mainfrom
HengYangDS:fix/desktop-link-title-ssrf-socks-publish-20260718
Closed

HengYangDS wants to merge 1 commit into
NousResearch:mainfrom
HengYangDS:fix/desktop-link-title-ssrf-socks-publish-20260718

Conversation

@HengYangDS

Copy link
Copy Markdown

Summary

  • Gate title URLs and redirects against public-address admission.
  • Pin DNS answers through a loopback SOCKS gateway to resist rebinding and direct fallback.
  • Fail closed for renderer proxy setup and WebRTC/popup policy failures.
  • Add a real Electron hidden BrowserWindow test proving SOCKS routing and an unreachable proxy does not direct-connect.

Verification

  • Electron link-title suites: 44 passed.
  • UI URL-admission suite: 34 passed.
  • npm run typecheck and targeted ESLint passed.

Note

The full Electron project suite has a pre-existing timeout in electron/git-review-ops.test.ts, reproduced unchanged on the untouched local main checkout; it is not included in this PR scope.

@alt-glitch alt-glitch added type/security Security vulnerability or hardening P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data needs-repro Bug needs reproduction steps duplicate This issue or pull request already exists labels Jul 17, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

This was generated by AI during triage.

Duplicate of #65613 — this later submission keeps the same link-title admission, DNS-pinning, SOCKS-routing, and fail-closed transport implementation; its additional timeout handling and E2E coverage are refinement of that open PR.

@HengYangDS
HengYangDS force-pushed the fix/desktop-link-title-ssrf-socks-publish-20260718 branch from a8921b5 to de838d3 Compare July 17, 2026 19:18
@HengYangDS
HengYangDS marked this pull request as ready for review July 18, 2026 05:10
@HengYangDS

Copy link
Copy Markdown
Author

Superseded by #65613. Its unique Electron pinned-proxy E2E coverage was transferred to #65613 in a36ab2914; closing this duplicate to keep security review on one canonical branch.

@HengYangDS HengYangDS closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) duplicate This issue or pull request already exists needs-repro Bug needs reproduction steps P3 Low — cosmetic, nice to have sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants