fix(config): parse structured config values - #66439
Closed
HengYangDS wants to merge 1 commit into
Closed
Conversation
HengYangDS
marked this pull request as ready for review
July 17, 2026 18:08
Collaborator
HengYangDS
marked this pull request as draft
July 17, 2026 18:59
HengYangDS
force-pushed
the
fix/config-structured-mapping-20260718
branch
from
July 17, 2026 19:14
8d64ac7 to
7df3781
Compare
HengYangDS
marked this pull request as ready for review
July 18, 2026 05:10
Author
|
Closing as superseded by #64389. #64389 contains this PR's list/mapping coercion fix and additionally validates known scalar/structured types, rejects malformed or non-JSON-compatible values before any write, and covers config-to-env round trips. Keeping one stronger review surface avoids duplicate maintenance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quick_commands.Verification
scripts/run_tests.sh tests/hermes_cli/test_set_config_value.py tests/hermes_cli/test_config.py tests/hermes_cli/test_config_validation.py tests/hermes_cli/test_config_drift.py tests/hermes_cli/test_config_env_expansion.py tests/hermes_cli/test_config_env_refs.py -- -qruff check hermes_cli/config.py tests/hermes_cli/test_set_config_value.pyTDD evidence
Before the production change, the new list/mapping regression tests failed because both values were persisted as strings (57 passed, 2 failed). After the minimal change, the same test file passed (59 passed, 0 failed).