fix(cli): stop creating .install_method in Git checkout (#66189)

[lEWFkRAD]

Fixes #66189

[alt-glitch]

This was generated by AI during triage.

Related: #54855 already supplies the focused .install_method ignore. This PR includes that correction alongside substantial unrelated fork/WIP changes; please split or rebase the targeted fix before review.

[tonydwb]

Code Review Summary

Verdict: Approved

Clean, well-scoped change with good test coverage. No security concerns.

---

Reviewed by Hermes Agent

[teknium1]

Thanks for identifying a real updater annoyance. The premise still holds on current main: hermes_cli/config.py:503 writes the checkout-local marker, while hermes_cli/main.py:6534-6565 checks porcelain status and autostashes untracked files. The root-scoped rule in commit a1ad6a09081eb80877ed41eb9093ea8c72b0c861 addresses that path.

Problems

• The PR diff contains 51 files and 10,516 added lines unrelated to #66189, including AMDP, platform, telemetry, pet, and backup-artifact changes. The focused final commit changes only .gitignore and tests/test_install_sh_install_method_stamp.py.
• The unrelated AMDP work adds the user-facing reviewer_max_tokens setting at agent/amdp/config.py:172 (also documented at agent/amdp/ACTIVATION.md:48), which conflicts with the standing no-user-facing-max_tokens policy.
• tests/test_install_sh_install_method_stamp.py:42 checks for a literal .gitignore string rather than Git ignore behavior or the updater contract.

Suggested changes

• Rescope to the focused .install_method ignore change and add behavioral Git/update coverage.

Automated hermes-sweeper review.

[GottZ]

This was generated by AI during triage.

Summary

Five PRs address #66189 by ignoring the installer-created root .install_method marker; #66322 and #67364 also add regression coverage, with #67364 exercising the updater's exact untracked-autostash command. #67364 is the merged reference implementation and the recorded best fix for this issue.

Related pull requests

• fix: add .install_method to .gitignore #54855 duplicate — (+1/-0) — n/a: Adds an unscoped .install_method ignore rule, directly preventing the runtime marker from dirtying the checkout. Despite the maintainer-bot keep-open review, merged chore(gitignore): ignore installer .install_method stamp (salvage of #54855) #67364 now supplies the root-scoped rule plus the requested behavioral regression coverage.
• fix: ignore installer-created .install_method runtime stamp (#66189) #66216 [closed] fixes — (+6/-0) — n/a: Adds the same ignore rule with explanatory comments next to existing runtime-state markers. It remains relevant as a closed duplicate of fix: add .install_method to .gitignore #54855, as confirmed by two contributor comments.
• fix(cli): stop creating .install_method in Git checkout (#66189) #66322 fixes — (+38/-1) — n/a: The visible diff adds root-scoped /.install_method and a hermetic git check-ignore test, rather than stopping marker creation as its title suggests. Despite the contributor keep-open review, its requested focused salvage is superseded by merged chore(gitignore): ignore installer .install_method stamp (salvage of #54855) #67364, whose test additionally runs the updater's exact git stash push --include-untracked path.
• chore(gitignore): ignore .install_method installer marker (#66189) #66723 [closed] fixes — (+2/-0) — n/a: Adds the same root-scoped ignore rule without tests. It remains relevant as a closed duplicate of the earlier focused fix: add .install_method to .gitignore #54855, matching the contributor triage comment.
• chore(gitignore): ignore installer .install_method stamp (salvage of #54855) #67364 [merged] best fix — (+55/-0) — n/a: Adds root-scoped /.install_method and a regression test proving the marker survives and stays absent from status under the updater's exact untracked-autostash command. This merged salvage of fix: add .install_method to .gitignore #54855 is the recorded best fix and reference implementation for [Bug]: Installer-created .install_method dirties Git checkouts #66189.

Duplicates

#54855, #66216, #66322, #66723, and #67364 share the same core .install_method ignore correction; #66322 adds git check-ignore coverage, while #67364 adds the stronger updater-autostash regression. #66216 and #66723 were already closed as duplicates of #54855, and #67364 ultimately supersedes the remaining variants.

Suggested consolidation

Close #54855 and #66322 as already implemented on main by merged #67364: its root-scoped rule is identified in the maintainer-bot evidence at commit 211edd5e08d5, and the merged diff includes tests/hermes_cli/test_update_autostash.py::test_install_method_marker_not_autostashed_by_update. This preserves the recorded best-fix verdict for #67364; #66216 and #66723 should remain closed in the duplicate chain #66216/#66723 → #54855 → #67364.

Complex graph

flowchart TD
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I66189(["issue #66189 (closed)"])
    subgraph Dup54855 ["PRs duplicating each other"]
        P54855["PR #54855 (open)"]
        P66216["PR #66216 (closed)"]
        P66322["PR #66322 (open)"]
        P66723["PR #66723 (closed)"]
        P67364["PR #67364 (merged)"]
    end
    P66322 -->|fixes| I66189
    class I66189 closed
    class P54855 open
    class P66216 closed
    class P66322 open
    class P66723 closed
    class P67364 merged
    class P67364 best
    class P66322 target
    click I66189 "https://github.com/NousResearch/hermes-agent/issues/66189"
    click P54855 "https://github.com/NousResearch/hermes-agent/pull/54855"
    click P66216 "https://github.com/NousResearch/hermes-agent/pull/66216"
    click P66322 "https://github.com/NousResearch/hermes-agent/pull/66322"
    click P66723 "https://github.com/NousResearch/hermes-agent/pull/66723"
    click P67364 "https://github.com/NousResearch/hermes-agent/pull/67364"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 5 pull requests and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 7 kB of PR diffs, 7 kB of issue/PR text, 5 kB of discussion (15 comments), 6 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.