fix(desktop): keep new-session windows isolated from remembered routes

[deniqlab]

Summary

• Prevent the desktop shell from restoring shared remembered route/session state into compact new=1 new-session windows.
• Add a focused regression test for the helper that gates remembered-location restore behavior.

Why

New-session windows were inheriting the primary renderer's remembered route/session and starting from stale conversation context instead of a clean draft.

Validation

• npx vitest run --project ui src/app/contrib/hooks/use-desktop-integrations.test.ts
• npx tsc --noEmit -p apps/desktop/tsconfig.json
• npm run lint
• npm run test:ui
• npm run build
• git diff --check

[alt-glitch]

This was generated by AI during triage.

Related to #51117 and #57911 in the desktop remembered-workspace/session-routing family; this PR specifically isolates compact new-session windows from shared remembered history.

[tonydwb]

Code Review Summary

Verdict: Approved (LGTM)

Overview

Desktop session window isolation fix. +52/0, minimal and focused.

Security

• No hardcoded secrets or credentials

Code Quality

• Clean fix for window routing isolation

Looks Good

• Minimal, targeted fix

---

Reviewed by Hermes Agent

[teknium1]

Thanks for isolating both directions of the shared remembered-state path. The underlying issue is confirmed on current origin/main: apps/desktop/src/app/contrib/hooks/use-desktop-integrations.ts:64-99 persists and restores remembered state whenever the new-session window starts at NEW_CHAT_ROUTE, while apps/desktop/electron/session-windows.ts:46-47 deliberately gives those windows new=1#/.

Problems

• apps/desktop/src/app/contrib/hooks/use-desktop-integrations.ts:155 changes the deep-link quote replacement from one that emits an escaped quote to one that emits an unescaped quote. This unrelated edit can break /blueprint values containing whitespace and quotes; please retain the existing escape behavior.
• apps/desktop/src/app/contrib/hooks/use-desktop-integrations.test.ts:6-25 only tests exported helpers, not their use by the hook. The regression is at the effect boundary, so this test would not catch removed or inverted hook guards.

Suggested changes

• Remove the unrelated escaping edit at use-desktop-integrations.ts:155.
• Add a hook-level regression test asserting a new=1 window neither reads/writes remembered state nor navigates; the related PR #67049 contains that test shape.

Automated hermes-sweeper review.

[teknium1]

This unrelated change removes the emitted backslash before an embedded quote: the previous replacement produced \", while this one produces ". Please retain the existing deep-link escaping behavior; quoted /blueprint parameter values containing whitespace and quotes otherwise become malformed.

[teknium1]

This tests only a pure helper, not the hook effects that read/write shared remembered state. Please add or replace this with a renderHook regression that mocks isNewSessionWindow() and asserts no remembered-state access and no navigation.

[GottZ]

This was generated by AI during triage.

Summary

Sixteen PRs address distinct Desktop persistence, restore, routing, queue, and stream-attribution facets in this issue complex. The diffs range from pin hydration and stale-route recovery to new-window/profile isolation, cross-session submit guards, queue-lineage protection, and per-stream event pins; several closed PRs remain useful as superseded or merged reference implementations.

Related pull requests

• fix(desktop): restore pinned sessions after restart #39360 [closed] best fix — (+82/-30) — n/a: Hydrates pinned sessions missing from the bounded first page, but its fallback can select an unrelated FTS hit and its post-await write lacks a request-generation recheck; closed because Pins are server-owned, so they survive paging and follow you between apps #74234 superseded it with server-owned pins.
• fix(desktop): stop pinning stale message at top on chat switch / compaction (#39959) #39995 [closed] best fix — (+9/-5) — n/a: Remounts threads per session and keys inner virtualized messages by stable IDs to prevent stale-row reuse; closed because commit 76b9386 removed the targeted virtualizer and current list.tsx implements the replacement path.
• fix(desktop): bind queued sends to their source session #56444 [closed] best fix — (+102/-43) — n/a: Threads runtime and stored IDs through queued submission and recovery, but snapshots ownership only at drain time rather than enqueue time; closed as superseded by merged fix(desktop): drain queued prompts to their originating session (supersedes #57849) #66001, which binds entries to their originating session and adds background draining.
• fix(desktop): gate messaging session polling #58332 partial — (+75/-10) — n/a: Gates the 10-second messaging-session poll behind evidence that messaging is in use, reducing unnecessary scans; this is a distinct optimization because the reported repeated backend spawn is already prevented on main by 56a8e81.
• fix(desktop): fall back to the engine's most recent session when the boot-restored chat is dead #60607 [closed] best fix — (+106/-5) — n/a: Uses terminal resume exhaustion to move an automatically restored dead session to the most recent eligible session or new chat while preserving manual-open Retry behavior; closed but remains the recorded best existing fix for Desktop cold boot restores a stale pinned session id instead of falling back to the engine's most recent session #60541.
• fix(desktop): keep new-session windows isolated from remembered routes #66270 fixes — (+52/-7) — n/a: Prevents compact new-session windows from reading or overwriting shared remembered navigation, but includes an unrelated quote-escaping regression and tests helpers rather than the hook boundary; despite its keep_open review, fix(desktop): isolate new-session windows #67049 covers the same guards with the requested hook-level regression.
• fix(desktop): isolate new-session windows #67049 best fix — (+84/-2) — n/a: Gates both remembered-state persistence and restoration with isNewSessionWindow() and verifies at the hook boundary that a standalone draft neither accesses remembered state nor navigates; it is the recorded best existing fix for Desktop: new session window reuses existing agent context (no session isolation) #65596, Desktop: new session window reuses existing agent context (no session isolation) #65597, [Bug]: Desktop new session window reuses existing agent context — no session isolation #65598, and [Bug]: Desktop new session window reuses existing agent context — no session isolation #65601.
• fix(desktop): preserve fresh-session title routing #67091 [closed] related — (+140/-19) — n/a: Makes an explicitly remembered new-chat route outrank a stale session ID and protects transient restore navigation; closed as intentionally abandoned, but remains a reference for the separate fresh-draft title/restore invariant.
• fix(desktop): scope restored navigation by profile (#67709) #67823 best fix — (+388/-40) — n/a: Adds profile-scoped route/session storage, profile-readiness gating, and ownership validation for restored session routes; it remains the recorded best existing fix for Desktop cold-start restore can resume a session into the wrong profile and create duplicate session IDs #67709 but needs manual reconciliation with partial fix 143942d and merged fix(desktop): scope the remembered route per profile #74277.
• fix(desktop): fall back from stale boot session #68181 partial — (+184/-6) — n/a: Validates remembered sessions through the bounded session list and falls back after refresh failure, but that can misclassify transient backend failure as staleness and bypass newer profile scoping; fix(desktop): fall back to the engine's most recent session when the boot-restored chat is dead #60607 provides the safer resume-exhaustion design.
• fix(desktop): isolate New Window from remembered sessions #69815 fixes — (+110/-9) — n/a: Marks full peer windows with win=instance and suppresses root-route restore/write behavior, but its helper-only test misses the effect boundary and the branch conflicts with profile-scoped state; it overlaps fix(desktop): keep new-session windows isolated from remembered routes #66270 and the stronger hook-tested fix(desktop): isolate new-session windows #67049 while covering a distinct full-peer window entry point.
• fix(desktop): close cross-session leak windows in composer + session refs (#59305) #70610 [closed] fixes — (+651/-27) — n/a: Closes passive-effect races in session refs and composer attachments and adds submit-time composer/session coherence checks; closed because merged fix(desktop): close cross-session leak windows in composer + session refs #70986 carries the fix and authorship while dropping only the infographic asset.
• fix(desktop): close cross-session leak windows in composer + session refs #70986 [merged] best fix — (+651/-27) — n/a: Merged reference implementation for [Desktop] Chat tab messages leak across sessions — cross-tab content mixing #59305 and [Desktop] Root cause of #59305: two passive-effect race windows + missing composer/session coherence check on submit #70609, synchronizing session refs, switching attachment scope before paint, preferring route identity, and rejecting incoherent submits with regression coverage.
• fix(desktop): scope the remembered route per profile #74277 [merged] partial — (+83/-9) — n/a: Merged partial implementation that scopes remembered routes by the same profile owner as remembered session IDs; it overlaps fix(desktop): scope restored navigation by profile (#67709) #67823 but does not include that PR's profile-adoption gate or explicit route-session ownership validation.
• fix(desktop): keep queued prompts bound to their origin session #74581 [merged] best fix — (+158/-6) — n/a: Merged reference implementation that restricts composer/queue migration to same-lineage rekeys and makes background drain gates lineage-aware, preventing Session A queues from being re-homed and drained into Session B.
• fix(desktop): track one unscoped stream pin per session #77826 partial — (+237/-37) — n/a: Replaces the shared unscoped-stream slot with concurrent per-session pins, retires only the completed stream, and drops genuinely ambiguous events instead of attributing them to the wrong transcript; this addresses the remaining event-attribution path described in Bug: "Session Zombie" queue lock and UI state leaks during session switching in Desktop App #62823.

Duplicates

#66270 and #67049 implement the same compact new-session remembered-state guards, with #67049 adding the hook-boundary regression requested on #66270; #69815 overlaps that family for full peer windows. #70610 is superseded by merged #70986, #56444 by merged #66001, and the queue-migration portion of the complex is implemented by merged #74581.

Suggested consolidation

Keep #67049 open with its hook-level regression as the recorded best fix for the new-session-window isolation reports, and close #66270 as its duplicate despite the keep_open review: #67049 preserves the same two guards while avoiding #66270's unrelated quote-escaping change and addressing the review's missing effect-boundary test. Keep #69815 open only with a salvage path for its distinct win=instance URL marking after rebasing onto profile-scoped state and adding the requested hook test; separately, author action on #67823 is to rebase and split out the profile-readiness and ownership-validation pieces not already implemented by #74277, while #58332 and #77826 should remain open for their distinct polling and concurrent-stream fixes.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I65596(["issue #65596 (closed)"])
    I65597(["issue #65597 (closed)"])
    I65598(["issue #65598 (closed)"])
    I65601(["issue #65601 (open)"])
    subgraph Dup66270 ["PRs duplicating each other"]
        P66270["PR #66270 (open)"]
        P67049["PR #67049 (open)"]
        P69815["PR #69815 (open)"]
    end
    P66270 -->|fixes| I65596
    P66270 -->|fixes| I65597
    P66270 -->|fixes| I65598
    P66270 -->|fixes| I65601
    class I65596 closed
    class I65597 closed
    class I65598 closed
    class I65601 open
    class P66270 open
    class P67049 open
    class P69815 open
    class P67049 best
    class P67049 best
    class P67049 best
    class P67049 best
    class P66270 target
    click I65596 "https://github.com/NousResearch/hermes-agent/issues/65596"
    click I65597 "https://github.com/NousResearch/hermes-agent/issues/65597"
    click I65598 "https://github.com/NousResearch/hermes-agent/issues/65598"
    click I65601 "https://github.com/NousResearch/hermes-agent/issues/65601"
    click P66270 "https://github.com/NousResearch/hermes-agent/pull/66270"
    click P67049 "https://github.com/NousResearch/hermes-agent/pull/67049"
    click P69815 "https://github.com/NousResearch/hermes-agent/pull/69815"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 16 pull requests and 21 issues in this complex. Each diff was read against this issue; Assessment working set: 207 kB of PR diffs, 89 kB of issue/PR text, 53 kB of discussion (62 comments), 66 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.