fix(models): add gpt-5.4 and gpt-5.4-mini to openai-codex static model list - #6618
Closed
ygd58 wants to merge 1 commit into
Closed
fix(models): add gpt-5.4 and gpt-5.4-mini to openai-codex static model list#6618ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
…l list _PROVIDER_MODELS["openai-codex"] was stale (v0.7.0 era) and missing the current production models gpt-5.4 and gpt-5.4-mini. Fixes NousResearch#6595
Contributor
|
Thanks for the contribution @ygd58! This fix was already applied to Automated hermes-sweeper review — closing as implemented on main.
No further changes are needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6595
Root Cause
_PROVIDER_MODELS["openai-codex"]was stale (v0.7.0 era) and missing the current production modelsgpt-5.4andgpt-5.4-mini.provider_model_ids()already callsget_codex_model_ids()for dynamic discovery, but when the Codex API is unreachable the fallback static list was shown in the/modelpicker — withoutgpt-5.4.Fix
Prepend
gpt-5.4andgpt-5.4-minito the static fallback list so they appear in the picker even when the live API is unavailable.Changes
hermes_cli/models.py: prependgpt-5.4andgpt-5.4-minito_PROVIDER_MODELS["openai-codex"]