fix(mcp): complete hosted OAuth across Dashboard and Desktop - #66151
Merged
Conversation
Collaborator
Related: salvages and extends #66090 with Desktop parity and profile-isolated hosted OAuth lifecycle handling. |
tonydwb
reviewed
Jul 17, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Completes hosted OAuth flow across Dashboard and Desktop (83K diff, 10 files). Given the OAuth/security scope, recommend human reviewer give final approval. OAuth implementation patterns should be verified by someone with direct access.
Reviewed by Hermes Agent
teknium1
force-pushed
the
salvage/66090-hosted-mcp-oauth
branch
from
July 17, 2026 11:39
c21627f to
6aba883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hosted MCP OAuth now completes through both the Web Dashboard and Desktop without loopback callbacks, while keeping profile credentials isolated and reauthorization atomic.
This salvages #66090 from @benbarclay onto current
mainand hardens the shared OAuth lifecycle discovered during review.Changes
Validation
Authorship
Infographic