Skip to content

fix(titles): use active runtime for TUI and ACP sessions (salvage #62983) - #66062

Merged
teknium1 merged 2 commits into
mainfrom
salvage/62983-title-runtime
Jul 17, 2026
Merged

fix(titles): use active runtime for TUI and ACP sessions (salvage #62983)#66062
teknium1 merged 2 commits into
mainfrom
salvage/62983-title-runtime

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Auto-title generation now uses the active session's runtime (model, provider, credentials, api_mode) on the Desktop/TUI and ACP (IDE) surfaces — previously only CLI and the messaging gateway passed it, so sessions on providers with runtime auth (e.g. OAuth/Codex-style credentials) stayed silently untitled on those two surfaces.

Salvages #62983 by @seagpt as-is — the PR was current against main, tested, and merged clean; only an AUTHOR_MAP entry was added on top.

Changes

  • tui_gateway/server.py, acp_adapter/server.py: pass main_runtime={model, provider, base_url, api_key, api_mode} from the active agent into maybe_auto_title, mirroring the exact dict shape cli.py and gateway/run.py already use (@seagpt)
  • Tests in both suites assert the runtime is forwarded (@seagpt)
  • scripts/release.py: AUTHOR_MAP entry (ours)

Validation

Before After
TUI/desktop session on runtime-auth provider titler falls back to auxiliary resolution → skipped → untitled uses active session's runtime
tests/test_tui_gateway_server.py + tests/acp/test_server.py 431 pass via run_tests.sh

Completes the surface matrix: all four maybe_auto_title call sites now pass the runtime. PR #44810 (which duplicated the TUI half from a stale base) will be closed with credit.

Infographic

title-runtime-surfaces

@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/acp Agent Communication Protocol adapter P3 Low — cosmetic, nice to have sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Jul 17, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment

Scope: New skill addition or minor change

Notes

  • Skill/content addition or minor fix.
  • No security concerns, no debug artifacts.
  • LGTM.

Reviewed by Hermes Agent

@teknium1
teknium1 force-pushed the salvage/62983-title-runtime branch from 5cd3859 to e7f8f11 Compare July 17, 2026 05:28
@teknium1
teknium1 force-pushed the salvage/62983-title-runtime branch from e7f8f11 to ee65fc6 Compare July 17, 2026 05:44
@teknium1
teknium1 merged commit 61be8b3 into main Jul 17, 2026
33 checks passed
@teknium1
teknium1 deleted the salvage/62983-title-runtime branch July 17, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/acp Agent Communication Protocol adapter comp/tui Terminal UI (ui-tui/ + tui_gateway/) P3 Low — cosmetic, nice to have sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants