fix(titles): use active runtime for TUI and ACP sessions (salvage #62983) - #66062
Merged
Conversation
tonydwb
reviewed
Jul 17, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Scope: New skill addition or minor change
Notes
- Skill/content addition or minor fix.
- No security concerns, no debug artifacts.
- LGTM.
Reviewed by Hermes Agent
teknium1
force-pushed
the
salvage/62983-title-runtime
branch
from
July 17, 2026 05:28
5cd3859 to
e7f8f11
Compare
teknium1
force-pushed
the
salvage/62983-title-runtime
branch
from
July 17, 2026 05:44
e7f8f11 to
ee65fc6
Compare
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-title generation now uses the active session's runtime (model, provider, credentials, api_mode) on the Desktop/TUI and ACP (IDE) surfaces — previously only CLI and the messaging gateway passed it, so sessions on providers with runtime auth (e.g. OAuth/Codex-style credentials) stayed silently untitled on those two surfaces.
Salvages #62983 by @seagpt as-is — the PR was current against main, tested, and merged clean; only an AUTHOR_MAP entry was added on top.
Changes
tui_gateway/server.py,acp_adapter/server.py: passmain_runtime={model, provider, base_url, api_key, api_mode}from the active agent intomaybe_auto_title, mirroring the exact dict shapecli.pyandgateway/run.pyalready use (@seagpt)scripts/release.py: AUTHOR_MAP entry (ours)Validation
tests/test_tui_gateway_server.py+tests/acp/test_server.pyCompletes the surface matrix: all four
maybe_auto_titlecall sites now pass the runtime. PR #44810 (which duplicated the TUI half from a stale base) will be closed with credit.Infographic