Skip to content

feat: add --search flag to 'hermes skills list' for filtering installed skills by name (#66021) - #66054

Closed
webtecnica wants to merge 2 commits into
NousResearch:mainfrom
webtecnica:feat/66021-skill-center-search
Closed

feat: add --search flag to 'hermes skills list' for filtering installed skills by name (#66021)#66054
webtecnica wants to merge 2 commits into
NousResearch:mainfrom
webtecnica:feat/66021-skill-center-search

Conversation

@webtecnica

@webtecnica webtecnica commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #66021 — adds a --search flag to hermes skills list so users can filter installed skills by name without piping through grep.

Changes

3 surgical changes, 2 files, +12 lines:

  1. hermes_cli/subcommands/skills.py — Added --search argument to the list subparser with default="" and help text.

  2. hermes_cli/skills_hub.py::do_list — Added search: str = "" parameter. Filters skills with a case-insensitive name substring match when non-empty. Filter is applied after source filter and before enabled-only filter, composable with both.

  3. hermes_cli/skills_hub.py::skills_command — Passes args.search (with getattr fallback to "") to do_list.

Usage

# List all installed skills matching "git"
hermes skills list --search git

# Combine with other filters
hermes skills list --search memory --source hub --enabled-only

Verification

  • Python parse OK on both modified files
  • No merge markers
  • Only 2 files touched, 12 lines added

@webtecnica
fix: cap prompt_cache_key at 64 chars to avoid OpenAI 400 error
74341d5 
OpenAI rejects prompt_cache_key values longer than 64 characters
with HTTP 400. Enforce a 64-char cap on the cache_key at its source
so both the kwargs path (line 271) and extra_body path (line 382)
benefit. Falls back to session_id when there is no static content.

Fixes NousResearch#66045
@webtecnica
feat: add --search flag to 'hermes skills list' for filtering install…
30a0bfd 
…ed skills by name (NousResearch#66021)
@alt-glitch alt-glitch added type/feature New feature or request comp/cli CLI entry point, hermes_cli/, setup wizard comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/openai OpenAI / Codex Responses API P2 Medium — degraded but workaround exists sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) needs-decision Awaiting maintainer decision before any implementation duplicate This issue or pull request already exists labels Jul 17, 2026
@alt-glitch

alt-glitch commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

The bundled Codex prompt_cache_key clamp duplicates the mechanism in earlier open PR #24273. This PR also contains the independent hermes skills list --search feature, so maintainers should decide whether to split that feature before disposition.

tonydwb
tonydwb reviewed Jul 17, 2026
View reviewed changes

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Nice addition. The --search flag is well-scoped: a single optional parameter, case-insensitive substring filter, consistent with the existing do_list interface. Code is minimal and reads cleanly. No issues found.

tonydwb
tonydwb reviewed Jul 17, 2026
View reviewed changes

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

tonydwb
tonydwb reviewed Jul 17, 2026
View reviewed changes

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: LGTM / Comment

The --search flag is a well-scoped, minimal feature addition. Implementation is clean: one new optional parameter with case-insensitive substring match, consistent with the existing do_list interface. No issues found.

tonydwb
tonydwb reviewed Jul 17, 2026
View reviewed changes

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment (resubmit — prior COMMENT activity noted)

Notes

  • Minor fix/feature.
  • No security concerns, no debug artifacts.
  • LGTM.

Reviewed by Hermes Agent

@webtecnica

webtecnica commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Fechando como duplicata — mesmo fix do #24273 (Codex prompt_cache_key truncation). Obrigado @alt-glitch! 🙏

@webtecnica webtecnica closed this Jul 17, 2026
@teknium1 teknium1 mentioned this pull request Jul 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tonydwb tonydwb tonydwb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists needs-decision Awaiting maintainer decision before any implementation P2 Medium — degraded but workaround exists provider/openai OpenAI / Codex Responses API sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A search function should be added to the skill center

3 participants

@webtecnica @alt-glitch @tonydwb