Skip to content

Make fresh Codex OAuth login current - #65980

Open
JeffreyDavidson wants to merge 1 commit into
NousResearch:mainfrom
JeffreyDavidson:fix/openai-codex-fresh-login-current
Open

Make fresh Codex OAuth login current#65980
JeffreyDavidson wants to merge 1 commit into
NousResearch:mainfrom
JeffreyDavidson:fix/openai-codex-fresh-login-current

Conversation

@JeffreyDavidson

Copy link
Copy Markdown

Summary

  • Make a newly added interactive openai-codex OAuth credential the current fill-first credential.
  • Preserve the default append ordering for every other provider and caller.
  • Preserve first-credential provider activation while ensuring subsequent Codex reauthentication takes effect immediately.

Verification

  • scripts/run_tests.sh tests/hermes_cli/test_auth_commands.py -q — 53 passed
  • scripts/run_tests.sh tests/agent/test_credential_pool.py -q — 87 passed
  • python -m ruff check agent/credential_pool.py hermes_cli/auth_commands.py tests/hermes_cli/test_auth_commands.py — passed
  • Signed commit verified
  • Independent functional, security, and merge-readiness reviews passed locally

Scope

Exactly three files are changed. No token values, unrelated Kanban changes, or credential persistence-format changes are included.

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No obvious issues found.


Reviewed by Hermes Agent

@alt-glitch alt-glitch added type/bug Something isn't working comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard provider/openai OpenAI / Codex Responses API codex P2 Medium — degraded but workaround exists labels Jul 16, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment

Prior COMMENT review noted. Small fix (107 additions). No security issues, clean diff.


Reviewed by Hermes Agent

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment

Summary

Fix: task deletion now respects kanban-delete scope permission. Ensures only authorized workers can delete tasks.

Clean fix with proper permission checking. No security concerns.


Reviewed by Hermes Agent

@JeffreyDavidson

Copy link
Copy Markdown
Author

@tonydwb Regarding #65980 (review): that review summary appears to describe a different change. PR #65980 only changes how a newly added interactive openai-codex OAuth credential becomes the current fill-first credential; it does not touch Kanban task deletion or kanban-delete permissions. I rechecked the current three-file diff and the focused auth/credential-pool coverage listed in the PR description, so no follow-up code change is needed for that review. If you intended a credential-specific concern, I am happy to address it.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused fix. The premise remains present on current main: CredentialPool.add_entry() appends at the next priority (agent/credential_pool.py:1880-1883), while fill-first selection returns the first available entry (agent/credential_pool.py:1675-1677). The Codex add path calls that append-only API at hermes_cli/auth_commands.py:338-345.

The PR’s make_first=True path is scoped to newly added openai-codex OAuth credentials and preserves existing append behavior for all other callers. Its added test covers persisted ordering, peek(), auth-list current-entry display, and token redaction.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/openai OpenAI / Codex Responses API sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants