feat(discord): searchable /model autocomplete

[FixItFoundry]

Supersedes #57796 (auto-closed when the head repo was deleted during my username migration). Addresses the review there: autocomplete catalog read offloaded via asyncio.to_thread, plus regression coverage in the connect/liveness suites.

[tonydwb]

Code Review Summary

Verdict: Comment

Looks Good

• Discord /model autocomplete is now searchable (fuzzy filter on model names)
• Clean addition to cron/jobs.py with corresponding test files
• No security or performance concerns

---

Reviewed by Hermes Agent

[teknium1]

Thanks for bringing searchable Discord /model selection forward; remote main still exposes /model only as a free-text field at plugins/platforms/discord/adapter.py:4247-4250, so the feature is still useful.

Problems

• plugins/platforms/discord/adapter.py:4392 truncates Choice.value. That changes the /model argument before gateway/slash_commands.py:1480-1487 parses --provider, so a long model ID or foreign-provider selection can no longer identify the intended target.
• The PR bundles unrelated cron, voice PCM, LoginFailure, and liveness changes. In particular, the new broad handler at plugins/platforms/discord/adapter.py:1345 precedes an existing broad handler at line 1359, leaving the latter unreachable.

Suggested changes

• Skip choices whose value cannot be represented intact; do not truncate them. Add tests for long values and for complete foreign-provider values.
• Isolate the /model autocomplete change from the unrelated commits, and consolidate the duplicate exception handling if the LoginFailure work is retained.

Automated hermes-sweeper review.

[FixItFoundry]

Thanks for the review — both points addressed, and the branch has been rebuilt on current main as a single commit.

Truncated Choice.value — fixed. You were right that this was silent corruption rather than a cosmetic cap. Values that exceed Discord's 100-character limit are now skipped outright instead of trimmed; the label is still ellipsised since it's display-only. Concretely, the old behaviour turned local-proxy/<long-id> --provider openrouter into …mmmm --provi, which drops the provider flag and resolves to a different target. test_model_autocomplete_preserves_values_verbatim pins it, and I confirmed it fails if the truncation is put back.

Bundled changes — removed. The PR is now only the /model autocomplete work: adapter.py, one line in tests/gateway/conftest.py, and the new tests. The unrelated commits are gone from this branch, which also removes the shadowed handler at the old line 1345 — the duplicate-handler question no longer applies here.

Two of them have been reopened standalone, addressing your point directly rather than dropping them:

• perf(discord): stream voice PCM to ffmpeg instead of a temp file #68157 — voice PCM→ffmpeg (found and fixed a WAV-header bug in the process)
• fix(discord): treat a rejected bot token as non-retryable #68158 — LoginFailure non-retryable, with the handler consolidated so the existing generic branch stays reachable, plus a regression test for exactly that

The cron and liveness changes were local-only and have been dropped rather than upstreamed.

One correction to the description, for the record: the autocomplete callback offloads the catalog build via asyncio.to_thread, since it reads the on-disk provider cache and doing that inline stalls the gateway on a cold cache.

[GottZ]

This was generated by AI during triage.

Summary

Four PRs are grouped with this complex, but only #54338, #61593, and #77380 address Discord category policy; #65931 is unrelated searchable /model autocomplete work. Of the category-policy PRs, #54338 extends existing channel scopes, #61593 introduces separate allowed/free category scopes, and recorded best-fix #77380 implements the issue's free, ignore, and inverse require-mention rules.

Related pull requests

• fix(discord): allow category-scoped channel policies #54338 partial — (+291/-36) — n/a: Extends the shared channel-key resolver with category IDs for allowed, ignored, free-response, no-mention admission, and slash paths, including channel/thread tests, but does not implement the issue's inverse require_mention_categories behavior. The contributor review says keep_open with medium salvageability after requiring preservation of existing key forms and coverage of the early admission path; the current diff contains those requested changes.
• feat(discord): add category channel gates #61593 partial — (+612/-22) — n/a: Adds separate allowed_categories and free_response_categories configuration, thread-parent resolution, early admission handling, slash authorization, tests, and documentation, but its visible diff does not add ignored-category or inverse require-mention rules. The contributor review says keep_open with medium salvageability, and the later contributor correction explicitly treats this as a distinct API alternative rather than a duplicate of fix(discord): allow category-scoped channel policies #54338.
• feat(discord): searchable /model autocomplete #65931 related — (+269/-1) — n/a: Implements authorized, searchable /model autocomplete with threaded catalog loading, filtering, Discord limits, intact model/provider values, and regression tests; it does not concern category mention or ignore rules. Its contributor review says keep_open with medium salvageability, and the visible diff reflects the documented follow-up by isolating autocomplete and skipping overlong values rather than truncating them.
• feat(discord): support per-category mention and ignore rules #77380 best fix — (+639/-4) — best fix for feat(discord): support per-category mention and ignore rules #38539 and feat(discord): support per-category mention and ignore rules #38540: Adds free_response_categories, ignored_categories, and require_mention_categories, including channel/thread inheritance, precedence, ingress admission, configuration bridging, and focused tests; this directly implements both additive and inverse regional behavior from the issue. It is the recorded best-fix PR for both issues and carries both structural closes edges.

Duplicates

Issues #38539 and #38540 are duplicates, as confirmed by contributor discussion. No exact PR duplicates remain: #54338 overlaps through overloaded channel scopes, #61593 is a contributor-confirmed separate category-API alternative, #77380 is the broader three-rule implementation, and #65931 is unrelated.

Suggested consolidation

Keep #77380 open with a salvage path centered on its complete three-rule contract and tests, because it is the recorded best fix for both duplicate issues; treat #38539 as canonical and close #38540 as its duplicate. Do not close #54338 or #61593 as duplicates without resolving the documented API choice, and keep #65931 outside this complex under its existing keep-open review.

Cross-PR triage: Reviewed 4 pull requests and 2 issues in this complex. Each diff was read against this issue; Assessment working set: 114 kB of PR diffs, 26 kB of issue/PR text, 15 kB of discussion (16 comments), 8 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

[FixItFoundry]

Rebased onto current main (057dcdf236) and conflict-resolved — the single commit is now 548f3d6a12. The adapter change auto-merged cleanly; the only conflict was test-file placement in tests/gateway/test_discord_slash_auth.py (resolved by appending the new tests after the existing skill-handler tests). All 5 autocomplete tests pass (-k autocomplete). Mergeable ✅ — ready for review.