fix(models): add kimi-for-coding-highspeed to kimi-coding static catalog (salvage #61901) - #65928
Merged
Merged
Conversation
alt-glitch
added
type/feature
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Looks Good
- Tiny addition: adds one model name to the static catalog
- Correct alphabetical placement within the kimi section
- No security or performance concerns
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
kimi-codingstatic model catalog now listskimi-for-coding-highspeed, so the high-speed Coding Plan tier appears in pickers even when live model discovery is unavailable.Salvage of #61901 by @liuhao1024 (cherry-picked with authorship preserved; PR base was stale). Fixes #61896; together with #65922 (dynamic
k3discovery), completes #65835.Changes
hermes_cli/models.py:kimi-for-coding-highspeedadded to_PROVIDER_MODELS["kimi-coding"], next to its siblingkimi-for-coding.Why
k3is NOT added staticallyk3was deliberately left out of the static floor: #65922 scoped it to the confirmedapi.kimi.com/codingendpoint (live-discovered there, filtered elsewhere), because legacy Moonshot keys share this provider and don't serve K3. A static entry would advertise it unconditionally and defeat that scoping — its regression tests (test_k3_live_discovery_is_scoped_to_kimi_coding_endpoint) fail ifk3enters the curated floor. Verified empirically before settling on this scope.kimi-for-coding-highspeedhas no such constraint (same base model/endpoint askimi-for-coding, tier-gated server-side).Validation
scripts/run_tests.sh tests/hermes_cli/test_models_dev_preferred_merge.py tests/plugins/model_providers/test_kimi_profile.py tests/hermes_cli/test_models.pyCredit: @liuhao1024 for the fix.
Infographic