chore: gitignore the code-scoped .install_method stamp - #65900
Closed
jtomek-strike48 wants to merge 1 commit into
Closed
chore: gitignore the code-scoped .install_method stamp#65900jtomek-strike48 wants to merge 1 commit into
jtomek-strike48 wants to merge 1 commit into
Conversation
The install-method stamp written by hermes_cli/config.stamp_install_method()
records how a specific install was set up ('git'/'pip'/'docker'/'nixos') next
to the running code, and is read back as the authoritative first signal in
detect_install_method(). It is per-environment runtime state, not source.
Committing it would poison detection for every other install (a pip install
of this tree would read a stale 'git' stamp instead of falling through to its
own detection), and the Docker image bakes its own value at build time. Ignore
it, alongside the analogous .update-incomplete runtime breadcrumb.
alt-glitch
added
type/bug
Collaborator
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
LGTM! Good documentation in the gitignore comment explaining why this stamp should not be committed.
Reviewed by Hermes Agent
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Looks Good
- Tiny chore: gitignore the
.install_methodstamp file (code-scoped) - No review concerns
Note
- Prior COMMENT review exists; this is a confirmation review
Reviewed by Hermes Agent
Contributor
|
Thanks for the focused fix. The premise holds on current main: Suggested changes
The member triage comment correctly notes that #54855 is a duplicate; selection between the two open contributions is a maintainer decision. Automated hermes-sweeper review. |
teknium1
added
sweeper:risk-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.install_methodis a per-environment runtime stamp, not source.hermes_cli/config.stamp_install_method()writes it next to the running code to record how this install was set up (git/pip/docker/nixos), anddetect_install_method()reads it back as the authoritative first signal.Committing it would poison detection for every other install: a
pipinstall of this tree would read a stalegitstamp instead of falling through to its own detection, and the Docker image bakes its own value at build time. So it belongs in.gitignore.Placed alongside the analogous
.update-incompleteruntime breadcrumb, with a matching explanatory comment.Changes
.gitignore: ignore.install_methodTest plan
git check-ignore .install_method→ matches (.gitignore)git statusclean with a local.install_methodpresentstamp_install_method()/detect_install_method()still read/write the physical file as before