Skip to content

fix(streaming): add jittered exponential backoff between stream retries #65832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drleadflow wants to merge 1 commit into from
Closed

fix(streaming): add jittered exponential backoff between stream retries #65832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions agent/chat_completion_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2799,8 +2799,29 @@ def _call_anthropic():
def _call():
import httpx as _httpx

from agent.retry_utils import jittered_backoff as _jittered_backoff

_max_stream_retries = env_int("HERMES_STREAM_RETRIES", 2)

def _backoff_before_retry(_attempt: int) -> None:

@teknium1 teknium1 Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add deterministic coverage for this helper: assert retry delays are requested and that setting _interrupt_requested during the sliced wait prevents the next stream request. The existing interrupt test covers a flag set before retry, not this new wait path.

"""Sleep with jittered exponential backoff between stream retries.

Back-to-back reconnects hammer a provider that is mid-outage and
compound rate-limit exposure. Sleep in short slices so /stop
(interrupt) stays responsive during the backoff window.
"""
_delay = _jittered_backoff(
_attempt + 1, base_delay=1.0, max_delay=15.0
)
_deadline = time.monotonic() + _delay
while True:
_remaining = _deadline - time.monotonic()
if _remaining <= 0:
return
if agent._interrupt_requested or _request_cancelled["value"]:
return
time.sleep(min(0.2, _remaining))

try:
for _stream_attempt in range(_max_stream_retries + 1):
# Check for interrupt before each retry attempt. Without
Expand Down Expand Up @@ -2952,6 +2973,7 @@ def _call():
)
except Exception:
pass
_backoff_before_retry(_stream_attempt)
continue

# SSE error events from proxies (e.g. OpenRouter sends
Expand Down Expand Up @@ -3018,6 +3040,7 @@ def _call():
)
except Exception:
pass
_backoff_before_retry(_stream_attempt)
continue
# Retries exhausted. Log the final failure with
# full diagnostic detail (chain, headers,
Expand Down