feat(cron): configure reasoning per job - #65679
Closed
the3asic wants to merge 1 commit into
Closed
Conversation
Collaborator
Duplicate of #7382 — this implements the same per-job |
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Comment
Overview
- Cron feature: configure reasoning per job
- 732 additions, 20 deletions — moderate size
Assessment
- Per-job reasoning configuration is useful for resource management
- No obvious security concerns
Note
- Given the moderate size, recommend verification that the reasoning configuration is properly validated
Reviewed by Hermes Agent
Contributor
Author
|
Closing in favor of #7382, which covers the same per-job reasoning-effort mechanism and remains the active implementation. Thanks for the triage. |
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
reasoning_effortoverride to each cron job, so scheduled work can choose its own quality/latency tradeoff without mutating global agent configuration.Runtime precedence is:
Behavior
nullinherits the configured policy.false/noneexplicitly disables reasoning.minimal,low,medium,high,xhigh,max,ultra.hermes cron edit <job_id> --reasoning-effort inheritclears an override.no_agent) jobs preserve the field but never construct an agent, so it has no runtime effect.reasoning_config; no job can leak its override into another job or global config.Surfaces
The field round-trips through cron storage, scheduler execution, the
cronjobtool, standalone CLI, authenticated dashboard API, web UI, desktop UI/types/translations, and cron documentation.Existing jobs require no migration and retain their current behavior.
Current-main compatibility
This is rebased onto current
mainand preserves the newer auth-fallback ordering: reasoning is resolved only after the actual fallback model is known. It also covers the gaps called out on earlier proposals: all current effort levels, raw YAML/JSONfalse, malformed-record fallback, standalone CLI set/clear, and both web and desktop surfaces.Related: #7382, #63327, #23524.
Validation
829 Python tests collected and passed across
tests/cron, cron tool, CLI parser/lifecycle, and dashboard profile API suitesWeb + desktop cron model Vitest: 16 passed
Web TypeScript typecheck: passed
Desktop renderer + Electron TypeScript typechecks: passed
ESLint on every changed frontend file: passed
Ruff on changed Python files: passed
py_compile: passedgit diff --check: passedAdded-line private identifier, IP, credential-literal, and control-character scans: zero hits
Tested on Ubuntu 26.04 (x86_64)