Skip to content

fix: add creationflags to remaining tts_tool subprocess calls #65667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
Closed

fix: add creationflags to remaining tts_tool subprocess calls #65667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/tts_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,7 @@ def _terminate_command_tts_process_tree(proc: subprocess.Popen) -> None:
stderr=subprocess.DEVNULL,
timeout=5,
stdin=subprocess.DEVNULL,
creationflags=windows_hide_flags(),
)
except Exception:
proc.kill()
Expand Down Expand Up @@ -2012,7 +2013,7 @@ def _generate_neutts(text: str, output_path: str, tts_config: Dict[str, Any]) ->
"--device", device,
]

result = subprocess.run(cmd, capture_output=True, text=True, timeout=120, stdin=subprocess.DEVNULL)
result = subprocess.run(cmd, capture_output=True, text=True, timeout=120, stdin=subprocess.DEVNULL, creationflags=windows_hide_flags())
if result.returncode != 0:
stderr = result.stderr.strip()
# Filter out the "OK:" line from stderr
Expand Down Expand Up @@ -2096,6 +2097,7 @@ def _resolve_piper_voice_path(voice: str, download_dir: Path) -> str:
"--download-dir", str(download_dir)],
capture_output=True, text=True, timeout=300,
stdin=subprocess.DEVNULL,
creationflags=windows_hide_flags(),
)
except subprocess.TimeoutExpired as exc:
raise RuntimeError(
Expand Down
Loading