fix(photon): launch the iMessage sidecar headless on Windows - #65441
Merged
Conversation
plugins/platforms/photon/adapter.py launches the Node sidecar (and the spectrum-ts mixed-attachment patch run) via subprocess without creationflags. On Windows this opens a visible console window on every sidecar (re)start -- and because a failed sidecar is retried on a timer, it flashes repeatedly. Wire windows_hide_flags() (hermes_cli/_subprocess_compat) into both spawns, the same helper the discord and whatsapp adapters already use for their sidecar spawns -- photon was the one platform adapter this pattern missed. CREATE_NO_WINDOW only (no DETACHED_PROCESS) so the persistent sidecar's stdin/stdout pipes stay usable for the supervisor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alt-glitch
added
type/bug
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Photon (iMessage) sidecar no longer pops visible console windows on Windows.
start_new_session=Trueis a silent no-op on Windows, so the long-lived Node sidecar spawned with an attached blank conhost window; the npm dep self-heal runs flashed one too.Changes
plugins/platforms/photon/adapter.py: sidecarPopenand the short-lived node patch run now passcreationflags=windows_hide_flags()(the sharedhermes_cli/_subprocess_compat.pyhelper —CREATE_NO_WINDOWonly, noDETACHED_PROCESS, so the stdin/stdout pipes stay usable) — @lEWFkRAD's fix from fix(photon): launch the iMessage sidecar headless on Windows #54565, cherry-picked with authorship preservedplugins/platforms/photon/adapter.py: follow-up widens the same flag to the sibling spawn sites in_reinstall_sidecar_deps(npm ci+npm installfallback)tests/plugins/platforms/photon/test_sidecar_lifecycle.py: regression coverage pinning the hidden-window spawn kwargsValidation
CREATE_NO_WINDOW, pipes intactscripts/run_tests.sh tests/plugins/platforms/photon/start_new_session=TrueCredit
Salvaged from #54565 by @lEWFkRAD (earliest submission, Jun 29). The same bug was independently fixed by @igparkernz-coder (#55554), @xIGBClutchIx (#56610), @ianarsenault-tn (#65083), and @smreed32 (#65299) — thanks to all five.
Infographic