fix(qqbot): add return_exceptions=True to asyncio.gather in chunked upload - #65370
Closed
x7peeps wants to merge 1 commit into
Closed
fix(qqbot): add return_exceptions=True to asyncio.gather in chunked upload#65370x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
Collaborator
Duplicate of #61302: both make the same one-line |
Contributor
Author
|
Closed as duplicate per maintainer feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
return_exceptions=Trueto theasyncio.gather()call in_run_with_concurrency()(gateway/platforms/qqbot/chunked_upload.py).Problem
When uploading a file via QQ Bot's chunked upload API, multiple parts are uploaded concurrently via
_run_with_concurrency(), which usesasyncio.gather()withoutreturn_exceptions=True.If any single part upload fails (network error, rate limit, transient HTTP error), the unhandled exception propagates through
gather(), cancelling all other in-flight part uploads and crashing the entire upload operation.This is the same class of bug already fixed in other gather calls (feishu #64864, context_references #64726, agent #62902).
Fix
One-line change: add
return_exceptions=Trueto theasyncio.gather()call at line 602, so per-part failures are isolated instead of cascading to all concurrent uploads.Testing