Conversation
teknium1
reviewed
Jul 16, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the focused regression test and narrow implementation.
Problems
apps/desktop/src/app/contrib/hooks/use-background-sync.ts:132changes a fresh draft to callrefreshCurrentModel(true). On current main,forceis intentionally reserved for profile swaps:apps/desktop/src/app/session/hooks/use-model-controls.ts:38-56preserves a non-empty composer selection, whileapps/desktop/src/app/session/hooks/use-session-actions/index.ts:210-215explicitly keeps that selection for new chats.- The referenced #62055 also reports that a Settings-selected model can be missing from the composer picker. This change resets the selection but does not address that catalog/availability path.
Suggested changes
- Keep the non-forced fresh-draft refresh unless maintainers choose to change the sticky-composer contract introduced in
cb6b4127e. - If targeting #62055, re-scope to the composer model-options path and test that the Settings-selected model is available and usable there.
Automated hermes-sweeper review.
| useEffect(() => { | ||
| if (gatewayState === 'open' && !activeSessionId && freshDraftReady) { | ||
| void refreshCurrentModel() | ||
| void refreshCurrentModel(true) |
Collaborator
There was a problem hiding this comment.
true overrides the deliberate sticky-composer contract: startFreshSessionDraft keeps the previous model/provider for new chats (apps/desktop/src/app/session/hooks/use-session-actions/index.ts:210-215), and refreshCurrentModel reserves force for profile swaps (apps/desktop/src/app/session/hooks/use-model-controls.ts:38-56). Please retain the non-forced call unless that product behavior is intentionally being changed.
Contributor
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the fresh-new-chat model seeding regression reported in #65300 / related #50821.
What changed
Verification
npm test -- src/app/contrib/hooks/use-background-sync.test.tsx src/app/session/hooks/use-model-controls.test.tsx✅git diff --check✅npm run lint -- src/app/contrib/hooks/use-background-sync.ts src/app/contrib/hooks/use-background-sync.test.tsx src/app/session/hooks/use-model-controls.test.tsx✅ (repo-level warnings only)npm run typecheck❌ blocked by baseline missing/incompatible desktop dependencies in this environmentnpm run build❌ blocked by baseline missing/incompatible assistant-ui exports in this environmentNotes
This branch is published from fork/deniqlab due push permissions on the upstream repo.