fix(cli): honor explicit local working directory

[deniqlab]

Closes #51636

Summary:

• Respect explicit local terminal.cwd values at CLI startup.
• Keep setup-generated local sessions on the launch-directory placeholder instead of persisting $HOME.
• Add regression tests for the CWD bridge and setup wizard defaults.

Verification:

• /Users/debuggerson/.hermes/hermes-agent/venv/bin/python -m pytest -q tests/cli/test_cwd_env_respect.py tests/cli/test_cli_new_session.py tests/gateway/test_config_cwd_bridge.py tests/hermes_cli/test_setup.py
• git diff --check

[teknium1]

Thanks for tracing the classic CLI bridge. The runtime premise is confirmed: current main overwrites local terminal.cwd with os.getcwd() in cli.py:603-605.

Problems

• tests/cli/test_cwd_env_respect.py:20 duplicates the proposed branch in _resolve_cwd instead of invoking cli.load_cli_config. It can remain green if the production loader changes independently. The repository requires behavior tests rather than source-shape/copy tests (AGENTS.md:1370-1404).
• This does not yet close #51636 as written. That issue reproduces with terminal.working_dir, while the runtime reads terminal.cwd (cli.py:603-605); the config env map has only cwd (hermes_cli/config.py:6905-6933) and config set does not normalize that alias (hermes_cli/config.py:8291-8300).

Suggested changes

• Test the real loader with an isolated config and patched launch directory.
• Either support/migrate terminal.working_dir with coverage, or remove Closes #51636 and keep this scoped to explicit terminal.cwd.

Automated hermes-sweeper review.

[teknium1]

This helper duplicates the production branch rather than exercising cli.load_cli_config, so the test can pass even if the real loader diverges. Please replace it with an isolated config fixture that imports the real loader, patches its Hermes home and launch cwd, and asserts the resulting terminal.cwd/TERMINAL_CWD behavior.

[GottZ]

This was generated by AI during triage.

Summary

33 PRs address or reference this issue complex across shell-snapshot CWD capture, CLI/Desktop CWD policy, prompt CWD reporting, the terminal.working_dir alias, and an unrelated personality-overlay path. For #51636 specifically, #51645 handles the reported alias while #65286 handles explicit terminal.cwd and setup defaults, but each visible contributor review identifies a remaining gap.

Related pull requests

• fix(terminal): honor configured cwd at session init #7802 [closed] fixes — (+29/-3) — n/a: Adds cd-before-snapshot handling in BaseEnvironment; closed because the equivalent implementation landed through fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205.
• fix: preserve configured cwd in local terminal snapshots #9798 [closed] fixes — (+4/-0) — n/a: Adds the same configured-CWD bootstrap cd; closed as already implemented by ac855bb, per the automated close verdict.
• fix: gateway respects terminal.cwd config and update preserves WorkingDirectory #11441 [closed] partial — (+180/-7) — n/a: Changes gateway process CWD and preserves customized systemd WorkingDirectory values; author-closed while reducing PR volume.
• fix(tools): respect configured terminal cwd during init #11708 [closed] best fix — (+31/-0) — n/a: Best existing fix recorded for [Bug]: Gateway working directory config not respected, and resets after update. #11312, inserting cd before snapshot capture; closed after the equivalent fix landed in fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205.
• fix(terminal): cd into configured cwd before capturing session snapshot (#7663) #11878 [closed] partial — (+71/-3) — n/a: Implements the same snapshot-CWD correction with broader quoting tests; closed and retained as historical duplicate evidence.
• fix(cli): bridge terminal.cwd config to TERMINAL_CWD in TUI gateway #14079 [closed] partial — (+282/-11) — n/a: Bridges terminal.cwd into the TUI gateway and makes completions resolve against TERMINAL_CWD; author-closed in favor of existing CWD work.
• fix(cli): respect terminal.cwd in chat sessions #14136 [closed] best fix — (+57/-5) — n/a: Best existing fix recorded for [Bug]: terminal.cwd is not respected by terminal tool #14044, covering shell initialization and CLI completion CWD; closed after its bootstrap portion landed through fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205.
• fix(terminal): use TERMINAL_CWD for local backend default_cwd #14264 [closed] related — (+27/-3) — n/a: Changes the local terminal default while bundling unrelated files; closed after contributor review found the relevant defect in init_session instead.
• fix(cli): respect terminal.cwd config in local terminal backend #14796 [closed] fixes — (+153/-0) — n/a: Restores configured CWD after login-profile scripts; closed because fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205 salvaged the same implementation and tests.
• fix(terminal): honor configured cwd at session init #14828 [closed] partial — (+42/-9) — n/a: Repeats the cd-before-pwd bootstrap fix; closed as a duplicate in the fix(terminal): honor configured cwd at session init #7802/fix: preserve configured cwd in local terminal snapshots #9798 chain.
• fix(terminal): honor configured cwd at session init #14830 [closed] partial — (+42/-9) — n/a: Carries effectively the same bootstrap and quoting diff as fix(terminal): honor configured cwd at session init #14828/fix(terminal): honor configured cwd at session init #14831; closed duplicate retained for chain accounting.
• fix(terminal): honor configured cwd at session init #14831 [closed] partial — (+42/-9) — n/a: Applies the bootstrap fix with explicit remote-backend rationale; closed after fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205 landed the equivalent implementation.
• fix(terminal): cd to configured cwd before shell snapshot capture #16762 [closed] partial — (+5/-0) — n/a: Adds a bootstrap cd before snapshot capture; closed as duplicate/no-op after contributor review of the command path.
• fix(terminal): restore configured cwd after login profile scripts (salvage #14796) #17205 [merged] best fix — (+153/-0) — n/a: Merged reference implementation and recorded best fix for [Bug]: Telegram/gateway ignores profile working directory (pwd returns ~/.hermes/hermes-agent) #7663 and [Bug]: Gateway working directory config not respected, and resets after update. #11312, restoring configured CWD before pwd capture across backends.
• fix(cli): prefer launch cwd for local sessions #19218 [closed] fixes — (+81/-31) — n/a: Separates interactive launch CWD from gateway-configured CWD using a runtime marker; closed as redundant with main.
• fix(cli): CLI/TUI on local backend always uses launch directory, ignores terminal.cwd #19242 [merged] partial — (+122/-72) — n/a: Merged historical implementation establishing launch-directory semantics for local CLI/TUI; later superseded in the fix chain by fix(cli): local backend CLI always uses launch directory #19334.
• fix(cli): local backend CLI always uses launch directory #19334 [merged] best fix — (+110/-120) — n/a: Merged recorded best fix for terminal.cwd config is a foot-gun: CLI/TUI should always use launch directory #19214, using an explicit gateway marker and removing stale terminal.cwd persistence to preserve the local CLI launch-directory contract.
• fix(prompt_builder): use TERMINAL_CWD in system prompt when configured #24888 [closed] fixes — (+31/-1) — n/a: Makes prompt environment hints prefer TERMINAL_CWD; closed as implemented on main by 1604765.
• fix(prompt_builder): use TERMINAL_CWD over os.getcwd() in environment hints #24957 [closed] fixes — (+35/-1) — n/a: Duplicates fix(prompt_builder): use TERMINAL_CWD in system prompt when configured #24888's TERMINAL_CWD-first prompt display fix; author-closed as duplicate of fix(prompt_builder): use TERMINAL_CWD in system prompt when configured #24888.
• fix(cron): use TERMINAL_CWD for system prompt working directory #24985 [closed] fixes — (+2/-1) — n/a: Applies the same prompt-reader correction to cron workdirs; author-closed as no longer relevant and later covered by fix(agent): resolve agent cwd from TERMINAL_CWD via one reader (closes #24882, #24969, #27383) #35028.
• fix(gateway): re-read terminal.cwd on session reset; use TERMINAL_CWD in environment hints #27488 [closed] partial — (+75/-4) — n/a: Re-bridges terminal configuration during gateway runtime reload; closed because merged fix(agent): resolve agent cwd from TERMINAL_CWD via one reader (closes #24882, #24969, #27383) #35028 covers the symptom without the branch's backend-leaking fallback, superseding the earlier keep_open review.
• fix(prompt): honor TERMINAL_CWD in local environment hints #31206 [closed] fixes — (+31/-1) — n/a: Another TERMINAL_CWD-first environment-hints patch with tilde expansion; closed as duplicate of fix(prompt_builder): use TERMINAL_CWD in system prompt when configured #24888.
• fix(agent): resolve agent cwd from TERMINAL_CWD via one reader (closes #24882, #24969, #27383) #35028 [merged] best fix — (+269/-9) — n/a: Merged recorded best fix for [Bug]: terminal.cwd not correctly injected into system prompt #24882, Cron --workdir not reflected in agent system prompt 'Current working directory' #24969, and [Bug]: change working directory for Telegram agent #27383, centralizing runtime CWD resolution for prompt display and context discovery.
• fix(cli): guard local-backend cwd resolution against a deleted CWD #40161 related — (+59/-2) — n/a: Guards local CWD resolution against a deleted launch directory; keep open with the high-salvage path identified by the automated review because it exercises the real loader and reuses _safe_getcwd().
• fix(cli): respect explicit terminal.cwd for local backend #42984 best fix — (+31/-16) — n/a: Recorded best fix for terminal.cwd config ignored for local backend — process cwd always used instead #42961, preserving explicit local terminal.cwd; keep open with the reviewed salvage path of real load_cli_config tests, complete docs, and an explicit CLI-versus-Desktop contract decision.
• fix(cli): respect explicit terminal.cwd path for local backend #43075 partial — (+31/-16) — n/a: Near-duplicates fix(cli): respect explicit terminal.cwd for local backend #42984 while adding partial documentation; its keep_open review requires real-loader tests, remaining documentation updates, and a scoped contract decision.
• fix(cli): honor explicit workspace cwd for local backends #50649 [closed] best fix — (+39/-5) — n/a: Recorded best fix for [Bug]: [Desktop] windows: cwd directory is the home directory by default, even with project directory set differently #50017, honoring launcher-provided Desktop workspace CWD; closed because session-specific propagation shipped in 59686df.
• fix(config): honor terminal.working_dir alias #51645 best fix — (+36/-1) — n/a: Recorded best fix for terminal.working_dir config is not applied on new session start #51636 because it normalizes the reported terminal.working_dir key, but the contributor keep_open review requires the same normalization in direct gateway and TUI YAML readers.
• fix(cli): respect explicit terminal.cwd for local backend (#42961) #59340 [closed] partial — (+105/-19) — n/a: Duplicates fix(cli): respect explicit terminal.cwd for local backend #42984's explicit-CWD guard while bundling an unrelated /proc search guard; author-closed as duplicate.
• fix(agent): respect ephemeral_system_prompt over stored DB prompt (#58774) #59360 [closed] partial — (+161/-19) — n/a: Changes cached system-prompt restoration and bundles unrelated CWD/file-tool work; closed for recreation from clean main and not part of the CWD cause.
• fix(agent): respect ephemeral_system_prompt over stored DB prompt (#58774) #59363 [closed] partial — (+57/-0) — n/a: Promotes the ephemeral overlay into the cached prompt, which conflicts with main's request-time overlay assembly despite COMMENTED approvals; closed as implemented by d682f32.
• fix(cli): honor explicit terminal.cwd on local backend #63092 [closed] related — (+116/-99) — n/a: Reverses the intentional local CLI launch-CWD contract with real-loader tests; author-closed after recognizing that a separate scoped workspace contract was needed.
• fix(cli): honor explicit local working directory #65286 related — (+48/-14) — n/a: Preserves explicit terminal.cwd and changes setup defaults, but the contributor keep_open review confirms it does not recognize the terminal.working_dir key used by terminal.working_dir config is not applied on new session start #51636 and its tests mirror rather than execute load_cli_config.

Duplicates

#7802, #9798, #11708, #11878, #14796, #14828, #14830, #14831, and #16762 substantially overlap with the bootstrap fix landed in #17205; #24888, #24957, #24985, and #31206 overlap with the prompt-reader fix consolidated in #35028. #42984, #43075, #59340, and #63092 share the explicit-local-CWD guard, while #51645 and #65286 are complementary rather than duplicates.

Suggested consolidation

Author action: rebase #51645 onto main and extend its terminal.working_dir normalization to the direct gateway and TUI YAML readers with regressions, exactly addressing its contributor keep_open review; it remains the recorded best fix for #51636. For #65286, address its keep_open review by replacing mirrored tests with real load_cli_config coverage and either incorporate the alias path without conflicting with #51645 or remove Closes #51636 and split the explicit-terminal.cwd/setup-default change into its own scoped issue; close #43075 as duplicate of #42984 if that separate CWD-contract work consolidates there.

Cross-PR triage: Reviewed 33 pull requests and 11 issues in this complex. Each diff was read against this issue; Assessment working set: 216 kB of PR diffs, 90 kB of issue/PR text, 49 kB of discussion (83 comments), 57 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.