Skip to content

fix: /learn writes to HERMES_HOME/skills instead of ~/.hermes/skills (#65165) - #65250

Closed
webtecnica wants to merge 1 commit into
NousResearch:mainfrom
webtecnica:fix/65165-learn-hermeshome
Closed

fix: /learn writes to HERMES_HOME/skills instead of ~/.hermes/skills (#65165)#65250
webtecnica wants to merge 1 commit into
NousResearch:mainfrom
webtecnica:fix/65165-learn-hermeshome

Conversation

@webtecnica

Copy link
Copy Markdown
Contributor

/reload-skills was using stale import-time SKILLS_DIR instead of dynamic get_skills_dir(). Changed scan_skill_commands() to use the dynamic resolver.\n\nCloses #65165

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) area/config Config system, migrations, profiles needs-decision Awaiting maintainer decision before any implementation labels Jul 15, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for investigating the HERMES_HOME symptom. This is an automated hermes-sweeper review; current main already provides the requested behavior.

  • Commit c6a3d412d (fix(skills): widen call-time skills-dir resolution to skill_manager_tool) is contained in current main and changed skill-manager path resolution to use the live profile-scoped home.
  • tools/skill_manager_tool.py:156-168 resolves the active skills root as get_hermes_home() / "skills", and _resolve_skill_dir() uses that helper at tools/skill_manager_tool.py:578-582.
  • hermes_constants.py:75-77 gives an explicit HERMES_HOME value precedence, so HERMES_HOME=/opt/data resolves creates under /opt/data/skills.
  • The current PR diff only adds a skills.allow_create gate in tools/skill_manager_tool.py; it does not alter the path resolver or scan_skill_commands().

The linked issue #65165 was also closed through PR #65212 with this current-main implementation.

@teknium1 teknium1 closed this Jul 16, 2026
@teknium1 teknium1 added sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles needs-decision Awaiting maintainer decision before any implementation P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/skills Skills system (list, view, manage) type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants