Skip to content

fix(photon): harden standalone send retries - #65203

Closed
paul-cch wants to merge 3 commits into
NousResearch:mainfrom
paul-cch:codex/photon-standalone-send-retry-upstream
Closed

fix(photon): harden standalone send retries#65203
paul-cch wants to merge 3 commits into
NousResearch:mainfrom
paul-cch:codex/photon-standalone-send-retry-upstream

Conversation

@paul-cch

Copy link
Copy Markdown

Summary

  • retry standalone Photon text sends after safe transient sidecar failures
  • retry httpx.ConnectError and ConnectTimeout, while leaving ambiguous read/write timeouts un-retried
  • fall back from markdown to stripped plain text after markdown attempts are exhausted
  • document and bound retry count and base delay via PHOTON_STANDALONE_SEND_RETRIES and PHOTON_STANDALONE_RETRY_BASE_DELAY_SECONDS

Context

Standalone sends are used by out-of-process delivery paths that reuse an already-running Photon sidecar. A transient sidecar or connection failure previously failed the whole delivery immediately.

This supersedes #53831. That PR was closed before review updates; after its head branch was rebased and force-updated, GitHub would not allow it to be reopened. The changes here address all review comments from #53831:

  • safe connection failures now enter the retry loop
  • read/write timeouts remain no-retry because the message may already have been delivered
  • both retry controls are documented in plugin.yaml and the Photon README
  • the unrelated inbound dedup timing change was removed from the diff

Tests

  • scripts/run_tests.sh tests/plugins/platforms/photon/ -> 117 passed
  • ruff check . -> passed
  • python scripts/check-windows-footguns.py --all -> passed

Copilot AI review requested due to automatic review settings July 15, 2026 20:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@paul-cch paul-cch closed this Jul 15, 2026
@paul-cch paul-cch reopened this Jul 15, 2026
@paul-cch paul-cch closed this Jul 15, 2026
@paul-cch
paul-cch deleted the codex/photon-standalone-send-retry-upstream branch July 15, 2026 20:49
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants