Skip to content

fix(dashboard): add MCP auth to profile builder - #65163

Merged
alt-glitch merged 3 commits into
mainfrom
sid/profile-builder-mcp-auth
Jul 15, 2026
Merged

alt-glitch merged 3 commits into
mainfrom
sid/profile-builder-mcp-auth

Conversation

@alt-glitch

@alt-glitch alt-glitch commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #65146 for the separate Create Profile wizard.

  • bring the Profile Builder MCP step to parity with the main MCP page: typed HTTP/SSE vs stdio transport, None/Bearer/OAuth selection, password-style Bearer input, and stdio environment assignments
  • refine the MCP picker with accessible segmented transport/auth controls, a responsive nested add-server form, a live configured count, and clearer server cards
  • share frontend request construction between both Dashboard MCP forms so transport-specific fields cannot drift
  • share backend request normalization between standalone MCP creation and profile creation while preserving the existing security rejection contract
  • write Bearer secrets only to the new profile's .env while config.yaml retains the interpolated Authorization header
  • preserve OAuth configuration for completion from the created profile's MCP page

Verification

  • all required GitHub Actions checks pass, including all eight Python shards, web, Desktop, security/lint, and amd64/arm64 Docker jobs
  • 138 affected backend tests passed after the final compatibility fix
  • 76 Dashboard tests passed
  • Dashboard TypeScript typecheck, targeted ESLint, and production build passed
  • full Desktop check passed locally: 204 test files and 1,716 passing tests, plus packaging and production builds
  • Ruff and diff whitespace checks passed

The backend coverage exercises Bearer-prefix stripping, profile-scoped .env persistence, safe config interpolation, OAuth persistence, stdio environment fields, invalid HTTP/auth combinations, and dangerous-entry rejection.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/dashboard Web dashboard / control panel UI (dashboard/, landing) area/auth Authentication, OAuth, credential pools sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Jul 15, 2026
@alt-glitch
alt-glitch marked this pull request as ready for review July 15, 2026 20:31
@alt-glitch
alt-glitch merged commit 56ab995 into main Jul 15, 2026
73 of 75 checks passed
@alt-glitch
alt-glitch deleted the sid/profile-builder-mcp-auth branch July 15, 2026 20:35
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
* fix(dashboard): add MCP auth to profile builder

* fix(dashboard): preserve MCP rejection error contract

* feat(dashboard): refine profile MCP picker
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
* fix(dashboard): add MCP auth to profile builder

* fix(dashboard): preserve MCP rejection error contract

* feat(dashboard): refine profile MCP picker
prmartinow pushed a commit to prmartinow/hermes-agent that referenced this pull request Aug 26, 2026
* fix(dashboard): add MCP auth to profile builder

* fix(dashboard): preserve MCP rejection error contract

* feat(dashboard): refine profile MCP picker
melon-xf added a commit to melon-xf/hermes-agent that referenced this pull request Sep 3, 2026
* fix(dashboard): add MCP auth to profile builder

* fix(dashboard): preserve MCP rejection error contract

* feat(dashboard): refine profile MCP picker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/cli CLI entry point, hermes_cli/, setup wizard comp/dashboard Web dashboard / control panel UI (dashboard/, landing) P3 Low — cosmetic, nice to have sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant