fix(desktop): copy conpty payloads file by file - #65055
Closed
WANGZHIHAOER wants to merge 1 commit into
Closed
WANGZHIHAOER wants to merge 1 commit into
WANGZHIHAOER wants to merge 1 commit into
Conversation
Contributor
Duplicate of #61832 — both fix the Windows |
Author
|
Closing as a duplicate of #61832. I independently reproduced the Windows recursive |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-ptyconpty payloads file by file in both prebuild andbuild/Releasestaging pathsEIO: Access is deniedfailure triggered by recursivefs.cpSyncon the conpty directoryWhy
On Windows, recursively copying the
node-ptyconpty directory can fail withEIO: Access is denied, while copying the contained DLL and executable files individually succeeds. This aborts the desktop rebuild during an update even though the web build has completed.The change reuses the existing filtered directory walker for conpty payloads only; all other build directories retain their current recursive-copy behavior.
Test plan
npm exec vitest run apps/desktop/scripts/stage-native-deps.test.mjs apps/desktop/scripts/before-pack.test.mjs— 21/21 passednpm run typecheck --workspace apps/desktopnpm run pack --workspace apps/desktopon Windows x64 — packaged successfully and producedrelease/win-unpacked/Hermes.exeFull-suite note
npm test --workspace apps/desktopcompleted with 1,688 passing and 8 failures in unrelated POSIX relaunch/path tests and existing UI tests. The unmodified main checkout reproduced the POSIX failures and failed the same UI area even earlier during module resolution.