fix(agent): fallback to latin-1 when loading repo .env in hermes_base_env - #6505
Closed
Dusk1e wants to merge 2 commits into
Closed
fix(agent): fallback to latin-1 when loading repo .env in hermes_base_env#6505Dusk1e wants to merge 2 commits into
Dusk1e wants to merge 2 commits into
Conversation
Collaborator
1 similar comment
Collaborator
Contributor
|
Thanks for the Windows encoding resilience work. This is an automated hermes-sweeper review; the requested behavior is already implemented on current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows users often run into a
UnicodeDecodeErrorright at the start because their.envfiles might be saved in regional encodings (like cp1252) rather than pure UTF-8. Since this happens during the initial import ofhermes_base_env, it effectively bricks the environment before it even starts.I've updated the loading logic to be more resilient. It now tries UTF-8 first, and if that fails, it falls back to Latin-1 instead of crashing. This ensures the agent can still boot even if there are non-ASCII characters in the config.
Key changes:
Test run:
python -m pytest tests/environments/test_hermes_base_env_env_loading.pypassed with 48 checks.