fix: make /history numbering match visible messages - #650
Conversation
The 200 lines of prompt_toolkit/rich/fire stubs added in PR #650 were guarded by 'if module in sys.modules: return' and never activated since those dependencies are always installed. Removed to keep the test file lean. Also removed unused MagicMock and pytest imports.
|
Merged (77f4776) and cleaned up dead module stubs in 4a09ae2 — the 200 lines of prompt_toolkit/rich/fire stubs were guarded and never activated since those deps are always installed. The /history fix itself is great — inline tool summaries, sequential numbering, better assistant display. Thanks @stablegenius49! |
|
Thanks for the fix @stablegenius49! The show_history() improvement is great — consistent numbering and tool message collapsing is exactly what was needed. However, this PR's branch is based on a much older version of main, so the diff includes unintended reversions of many features added since (skin engine, worktree isolation, checkpoints, auxiliary model config, etc.). The good news is the show_history fix was already applied to main in commit 77f4776. So the useful part of this PR is live — closing as superseded. Thanks again! |
|
Plan posted as planned, executing now. |
|
Resolution posted above. Fix is complete in PR #656. |
|
Resolved. PR #650 (fix/650-policy-code-body-size-limit) implements the fix:
Closing. |
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were guarded by 'if module in sys.modules: return' and never activated since those dependencies are always installed. Removed to keep the test file lean. Also removed unused MagicMock and pytest imports.
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were guarded by 'if module in sys.modules: return' and never activated since those dependencies are always installed. Removed to keep the test file lean. Also removed unused MagicMock and pytest imports.
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were guarded by 'if module in sys.modules: return' and never activated since those dependencies are always installed. Removed to keep the test file lean. Also removed unused MagicMock and pytest imports.
Summary
/historyTesting
pytest -q tests/test_cli_init.pypython3 -m py_compile cli.py tests/test_cli_init.pyCloses #633