Skip to content

fix: make /history numbering match visible messages - #650

Closed
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-633-history-display
Closed

fix: make /history numbering match visible messages#650
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-633-history-display

Conversation

@stablegenius49

Copy link
Copy Markdown
Contributor

Summary

  • number only visible user/assistant entries in /history
  • collapse skipped tool responses into a small summary instead of silently creating numbering gaps
  • show a clearer assistant placeholder for tool-call-only turns and allow longer previews

Testing

  • pytest -q tests/test_cli_init.py
  • python3 -m py_compile cli.py tests/test_cli_init.py

Closes #633

teknium1 added a commit that referenced this pull request Mar 8, 2026
The 200 lines of prompt_toolkit/rich/fire stubs added in PR #650 were
guarded by 'if module in sys.modules: return' and never activated since
those dependencies are always installed. Removed to keep the test file
lean. Also removed unused MagicMock and pytest imports.
@teknium1

teknium1 commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Merged (77f4776) and cleaned up dead module stubs in 4a09ae2 — the 200 lines of prompt_toolkit/rich/fire stubs were guarded and never activated since those deps are always installed. The /history fix itself is great — inline tool summaries, sequential numbering, better assistant display. Thanks @stablegenius49!

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the fix @stablegenius49! The show_history() improvement is great — consistent numbering and tool message collapsing is exactly what was needed.

However, this PR's branch is based on a much older version of main, so the diff includes unintended reversions of many features added since (skin engine, worktree isolation, checkpoints, auxiliary model config, etc.).

The good news is the show_history fix was already applied to main in commit 77f4776. So the useful part of this PR is live — closing as superseded. Thanks again!

@teknium1 teknium1 closed this Mar 10, 2026
@max-pristan

Copy link
Copy Markdown

Plan posted as planned, executing now.

@max-pristan

Copy link
Copy Markdown

Resolution posted above. Fix is complete in PR #656.

@max-pristan

Copy link
Copy Markdown

Resolved. PR #650 (fix/650-policy-code-body-size-limit) implements the fix:

  • Added _read_body() helper (router.py:46-53) that reads raw body and raises HTTP 413 if it exceeds 10 MB
  • All 6 endpoints now use _read_body(): /plan, /lint, /drift, /rollback, /impact, /sync-configs/{id}/resolve
  • Regression tests in tests/api/v1/policy_code/test_body_size_limit.py: 6/6 pass

Closing.

angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were
guarded by 'if module in sys.modules: return' and never activated since
those dependencies are always installed. Removed to keep the test file
lean. Also removed unused MagicMock and pytest imports.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were
guarded by 'if module in sys.modules: return' and never activated since
those dependencies are always installed. Removed to keep the test file
lean. Also removed unused MagicMock and pytest imports.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
The 200 lines of prompt_toolkit/rich/fire stubs added in PR NousResearch#650 were
guarded by 'if module in sys.modules: return' and never activated since
those dependencies are always installed. Removed to keep the test file
lean. Also removed unused MagicMock and pytest imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: /history command shows incomplete conversation — missing messages and confusing numbering

4 participants