test(codex): pin codex_backend issuer in xai-scoped salvage test - #64844
Merged
Conversation
test_normalize_codex_response_salvage_is_xai_scoped broke on main when two same-day merges crossed: #64764 (#64434 — trust response.status for reasoning-only turns on UNRECOGNIZED Responses backends) changed what a bare _normalize_codex_response(response) call returns for status='completed' reasoning-only output (now 'stop'), while #64768 added this test calling with no issuer_kind and expecting 'incomplete'. The test's intent is that the xAI reasoning-channel salvage does not leak into other special-cased backends — pin issuer_kind='codex_backend' so it exercises exactly that (same pattern as test_normalize_codex_response_treats_summary_only_reasoning_as_incomplete, which was already pinned for #64434).
alt-glitch
added
type/test
19 tasks
9 tasks
This was referenced Jul 15, 2026
This was referenced Jul 16, 2026
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…sResearch#64844) test_normalize_codex_response_salvage_is_xai_scoped broke on main when two same-day merges crossed: NousResearch#64764 (NousResearch#64434 — trust response.status for reasoning-only turns on UNRECOGNIZED Responses backends) changed what a bare _normalize_codex_response(response) call returns for status='completed' reasoning-only output (now 'stop'), while NousResearch#64768 added this test calling with no issuer_kind and expecting 'incomplete'. The test's intent is that the xAI reasoning-channel salvage does not leak into other special-cased backends — pin issuer_kind='codex_backend' so it exercises exactly that (same pattern as test_normalize_codex_response_treats_summary_only_reasoning_as_incomplete, which was already pinned for NousResearch#64434).
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…sResearch#64844) test_normalize_codex_response_salvage_is_xai_scoped broke on main when two same-day merges crossed: NousResearch#64764 (NousResearch#64434 — trust response.status for reasoning-only turns on UNRECOGNIZED Responses backends) changed what a bare _normalize_codex_response(response) call returns for status='completed' reasoning-only output (now 'stop'), while NousResearch#64768 added this test calling with no issuer_kind and expecting 'incomplete'. The test's intent is that the xAI reasoning-channel salvage does not leak into other special-cased backends — pin issuer_kind='codex_backend' so it exercises exactly that (same pattern as test_normalize_codex_response_treats_summary_only_reasoning_as_incomplete, which was already pinned for NousResearch#64434).
qxxaa
added a commit
to qxxaa/hermes-agent
that referenced
this pull request
Aug 14, 2026
… regression Rebase onto current main absorbs the issuer_kind="codex_backend" pinning in test_normalize_codex_response_salvage_is_xai_scoped (8fa8aab, NousResearch#64844), fixing CI. Add config-to-wire regression test per sweeper review: exercises agent.text_verbosity -> chat_completion_helpers -> normalized Codex request payload, covering both the injection and empty-default paths. Addresses feedback from NousResearch#59844 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a test broken on current
mainby two same-day merges crossing:test_normalize_codex_response_salvage_is_xai_scopedfails on every PR's CI (slice 8/8), including branches that don't touch codex code.Root cause: #64764 (issue #64434) changed
_normalize_codex_responseso an unrecognized issuer withstatus="completed"and reasoning-only output now trusts the provider and returnsstop. #64768 (merged 44 seconds later) added this test calling with noissuer_kindand expectingincomplete. Each PR was green against its own base; combined on main, the test asserts pre-#64434 behavior.Fix: pin
issuer_kind="codex_backend"in the test — its docstring says it guards the non-xAI special-cased backends (Codex replays encrypted reasoning, so continuation genuinely progresses), and that's exactly the path the pin exercises. Same pattern as the siblingtest_normalize_codex_response_treats_summary_only_reasoning_as_incomplete, which was already pinned for #64434. One test-line change, zero production code.Validation
tests/agent/test_codex_responses_adapter.pyon origin/mainReproduced on a pristine
origin/mainworktree (569b912) before fixing — the failure is pre-existing and unrelated to any open PR's changes.Infographic