fix(skills): strip duplicate description prefix + fix pinecone naming + add scripts/tests - #64619
Closed
immuhammadfurqan wants to merge 1 commit into
Closed
immuhammadfurqan wants to merge 1 commit into
immuhammadfurqan wants to merge 1 commit into
Conversation
…pts + tests - Rename research/pinecone to pinecone-research (distinct from mlops/pinecone) - Shorten mlops/pinecone description to <=60 chars - Add rag_pipeline.py and memory_manager.py scripts - Add test_pinecone_research_skill.py (10 tests: frontmatter, scripts, naming) - Remove unconditional description: prefix strip from extract_skill_description()
alt-glitch
added
type/bug
Contributor
Author
|
Closing in favor of the original updated PR #46519 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback from #46005.
Changes
Removed unconditional description: prefix strip extract_skill_description() receives parsed dicts, so the guard also strips legitimate values like "Description: setup steps.". Removed entirely since the upstream YAML duplicate-prefix bug is already fixed on main.
Renamed research Pinecone skill Changed from name: pinecone to name: pinecone-research to avoid conflicting with optional-skills/mlops/pinecone (installs keyed by bundle.name).
Shortened mlops/pinecone description From 246 chars to 47 chars (≤60 char standard).
Added scripts scripts/rag_pipeline.py (RAG indexing/querying) and scripts/memory_manager.py (namespace-based session memory).
Added tests tests/skills/test_pinecone_research_skill.py with 10 tests: frontmatter validation, ast.parse() syntax checks on both scripts, unique naming vs mlops/pinecone, and Pinecone SDK usage verification.
Test plan
python -m pytest tests/skills/test_pinecone_research_skill.py -v — all 10 tests pass
python -m pytest tests/agent/test_skill_utils.py -v — all existing tests pass