fix(email): restore gateway setup wizard - #64560
Draft
eddysayar wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thanks for the focused Email setup repair. Current main still reproduces the reported path: No blocking correctness or design-fit issue found. The PR base Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes gateway setupsetup_fnand complete required-env metadataPlatformConfig.extrafallback semantics in setup status detectionRoot cause
The bundled-platform migration in #49408 moved Email into a plugin, but Email did not register an interactive setup function. Selecting Email therefore fell through to environment-variable guidance instead of prompting for configuration. The plugin metadata also omitted
EMAIL_IMAP_HOSTand considered an address alone sufficient for connected status.Duplicate search
Searched open, closed, and merged issues/PRs for Email gateway setup, interactive setup,
setup_fn, andEMAIL_IMAP_HOST. No existing PR fixes this setup-hook regression. Related migration tracker: #41112.Test plan
scripts/run_tests.sh tests/gateway/test_email_plugin_setup.py tests/gateway/test_email.py tests/gateway/test_email_robustness.py tests/hermes_cli/test_gateway_platform_gating.py tests/hermes_cli/test_setup.py tests/hermes_cli/test_setup_irc.py -v --tb=shortgit diff --checkpassed