fix: make shutdown diagnostics portable without coreutils timeout - #64515
Open
faisfamilytravel wants to merge 1 commit into
Open
fix: make shutdown diagnostics portable without coreutils timeout#64515faisfamilytravel wants to merge 1 commit into
faisfamilytravel wants to merge 1 commit into
Conversation
faisfamilytravel
force-pushed
the
xo/fix-portable-shutdown-diagnostics
branch
from
July 14, 2026 16:43
c304a98 to
0b1cf9a
Compare
Contributor
|
Thanks for the focused portability fix. The premise is confirmed on current main: The PR base is an ancestor of the inspected HEAD and GitHub reports it mergeable; the targeted current-main code remains unchanged. The existing real subprocess/output test plus the new launcher regression cover the relevant contract. Automated hermes-sweeper review. |
This was referenced Jul 27, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gateway.shutdown_forensics.spawn_async_diagnostic()launches diagnostics through the GNUtimeoutexecutable. macOS does not shiptimeoutorgtimeout, so the supported macOS path catchesFileNotFoundError, returnsNone, and silently produces no shutdown diagnostic.Fix
Run the detached diagnostic through the current Python interpreter. The wrapper:
Popen.wait(timeout=...);Verification
timeoutnorgtimeoutinstalled.31 passedintests/gateway/test_shutdown_forensics.py.sys.executableand carries an internalTimeoutExpiredpath instead of invoking coreutils.