Skip to content

fix(honcho): use profile_host_key in peers display (dot vs underscore host-key mismatch) #64405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loveruncaged wants to merge 1 commit into from
Closed

fix(honcho): use profile_host_key in peers display (dot vs underscore host-key mismatch) #64405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/memory/honcho/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,12 @@ def _all_profile_host_configs() -> list[tuple[str, str, dict]]:
for p in profiles:
if p.name == "default":
continue
h = f"{HOST}.{p.name}"
# Use the same resolver as the runtime (profile_host_key) so the
# display looks up the correct block. The runtime derives host keys
# with an underscore separator and sanitization (e.g. "hermes_kristi"),
# not a dot ("hermes.kristi"), so a naive f"{HOST}.{p.name}" misses
# the real block and falsely shows "(not set)" / the raw host key.
h = profile_host_key(p.name)

@teknium1 teknium1 Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the legacy dot-key fallback when looking up this canonical key: use _host_block(cfg, h) in the append below. Runtime config resolution intentionally supports legacy hermes.<profile> blocks via plugins/memory/honcho/client.py:44-51; direct hosts.get(h, {}) would make peers misreport those still-supported configurations.

results.append((p.name, h, hosts.get(h, {})))

return results
Expand Down