Skip to content

fix(telegram): classify and dedup post-reconnect probe failures (#63243) - #64368

Merged
kshitijk4poor merged 1 commit into
NousResearch:mainfrom
kshitijk4poor:fix/63247-salvage
Jul 14, 2026
Merged

fix(telegram): classify and dedup post-reconnect probe failures (#63243)#64368
kshitijk4poor merged 1 commit into
NousResearch:mainfrom
kshitijk4poor:fix/63247-salvage

Conversation

@kshitijk4poor

Copy link
Copy Markdown
Collaborator

Summary

Salvage of #63247 (CI blocked for first-time contributor). Fixes #63243 — the post-reconnect probe () routed every failure into with no classification, bypassed the in-flight guard, and logged raw error text.

Changes

  • : probe failures now classified with shared (fix(telegram): classify PTB heartbeat transport errors #62098 classifier). Connectivity errors enter the recovery ladder via (picks up in-flight guard + guard + bookkeeping). Auth/validation errors log once (redacted) and don't trigger reconnect churn.
  • Both recovery entry points (wedged-updater and probe-failure) route through instead of ing the handler inline.
  • Tests updated to the scheduled-task semantics (assert registration).

Attribution

Cherry-picked from @SilentKnight87's #63247 with authorship preserved.

Validation

51 passed (telegram network reconnect + pending update probe). ruff + py_compile clean.

@kshitijk4poor
kshitijk4poor merged commit 2a0dd95 into NousResearch:main Jul 14, 2026
31 checks passed
@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins platform/telegram Telegram bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages P1 High — major feature broken, no workaround labels Jul 14, 2026
@kshitijk4poor
kshitijk4poor deleted the fix/63247-salvage branch August 5, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P1 High — major feature broken, no workaround platform/telegram Telegram bot adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(telegram): post-reconnect probe routes auth errors into reconnect ladder and bypasses the recovery dedup guard (gap left by #62098)

3 participants