docs: split agent guide into focused references - #64206
Open
fff-sissimo wants to merge 1 commit into
Open
Conversation
teknium1
reviewed
Jul 16, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused routing map and the effort to preserve the existing guide.
Problems
- The split omits the current test-placement policy. Current
AGENTS.md:1309-1319requires assertions aboutpackage.json, lockfiles, and JS/TS source to live in the Vitest suite because the CI classifier can skip Python tests on JS-only changes. That policy was added byf8abc521fafter this PR's base. The proposedreferences/agent-guide/testing.mdmoves from the wrapper explanation at lines 21-33 directly to change-detector guidance at line 36, so the rule would be lost.
Suggested changes
- Transplant
AGENTS.md:1309-1319intoreferences/agent-guide/testing.md, and validate the moved content against currentmainrather than only the PR base.
Automated hermes-sweeper review.
| | Locale | Whatever is set | C.UTF-8 | | ||
|
|
||
|
|
||
| ### Don't write change-detector tests |
Contributor
There was a problem hiding this comment.
Please add the current AGENTS.md:1309-1319 “Where to place what tests” policy before this heading. It was added in f8abc521f after this branch's base and requires JS/package-artifact assertions to live in Vitest; otherwise this split drops an active CI-safety rule.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdas a concise 129-line entry pointreferences/agent-guide/Validation
AGENTS.md: PASSgit diff --check: PASSTest plan