fix(cron): keep approval context task-local - #64194
Closed
adambiggs wants to merge 2 commits into
Closed
Conversation
Collaborator
Duplicate of #58663 — same mechanism and same three source files ( |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_CRON_SESSIONtask-local via the existing gatewayContextVarsession staterun_job()from permanently mutating the gateway process environmentBug
The cron scheduler runs inside the long-lived messaging gateway, but
run_job()sets:and never clears it. After the first scheduled job, later interactive Telegram turns are classified as cron. In a live DM,
execute_codeconsequently returned:instead of routing through the interactive approval flow.
Verification
The scheduler test also asserts that cron context is visible during the agent turn while
os.environremains untouched, and that cleanup removes the task-local marker.