fix(auxiliary): omit temperature for GPT-5 Responses - #63800
Open
AXEG0 wants to merge 2 commits into
Open
Conversation
teknium1
reviewed
Jul 16, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused regression coverage. Two issues need resolution before this can be salvaged.
Problems
- The added predicate matches
gpt-5.4(agent/auxiliary_client.py:408), but the unchanged test still expects that model to preservetemperature(tests/agent/test_auxiliary_client.py:3118-3132). The PR's test file therefore has conflicting expectations. - The predicate has no provider, endpoint, or API-mode check. Main explicitly keeps GPT-5 on chat completions for Nous and generic custom providers (
run_agent.py:1429-1437), and this helper also feeds the main chat path (agent/chat_completion_helpers.py:946-952). Meanwhile the Codex auxiliary Responses adapter already omits temperature (agent/auxiliary_client.py:971-972). The change needs to distinguish the affected LiteLLM/Responses route from non-Responses GPT-5 routes.
Suggested changes
- Reconcile the existing
gpt-5.4expectation with the intended contract. - Make the omission route-aware and add request-level coverage for both the affected route and a GPT-5 chat-completions route.
Automated hermes-sweeper review.
Author
|
Addressed both review points in fee1f188a2.
Validation: |
AXEG0
force-pushed
the
fix/aux-gpt5-temperature
branch
from
August 2, 2026 17:30
fee1f18 to
b64ccc5
Compare
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes auxiliary-request temperature handling route-aware for GPT-5 models.
When the resolved auxiliary route uses the Responses API (
codex_responses), the request omitstemperature, which that route rejects for affected GPT-5 models. Chat-completions routes—including custom providers and OpenRouter—continue to receive the caller's configured temperature. This keeps the fix aligned with the actual transport contract instead of applying a model-name-only rule.Related Issue
N/A — no public issue is linked.
Related/overlapping work:
Type of Change
Changes Made
agent/auxiliary_client.py: carry the resolved API mode through sync, async, and retry request builders; omit GPT-5 temperature only forcodex_responses; preserve existing Kimi and Arcee handling.tests/agent/test_auxiliary_client.py: add route-specific builder and request coverage proving Responses requests omit temperature while chat-completions requests preserve it.How to Test
scripts/run_tests.sh tests/agent/test_auxiliary_client.py -q.codex_responsesomittemperature.chat_completionspreserves the configuredtemperature.Focused result: 178 passed.
Additional checks:
ruff check .,git diff --check, andscripts/check-windows-footguns.py --allpass.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass (focused affected suite passes; the full GitHub Actions matrix is awaiting maintainer approval)Documentation & Housekeeping
docs/, docstrings) — N/A; no user-facing interface or behavior documentation changedcli-config.yaml.exampleif I added/changed config keys — N/A; no configuration keys changedCONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/A; no architecture or workflow changedScreenshots / Logs
N/A — regression coverage and command results are listed above.
AI Assistance
OpenAI — GPT-5 via Codex CLI (implementation assistance, test execution, and PR-description drafting).